From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A64C433FE for ; Wed, 13 Oct 2021 06:59:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A35A76103C for ; Wed, 13 Oct 2021 06:59:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A35A76103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 361A06B006C; Wed, 13 Oct 2021 02:59:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA93940008; Wed, 13 Oct 2021 02:59:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18B92940007; Wed, 13 Oct 2021 02:59:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 094536B006C for ; Wed, 13 Oct 2021 02:59:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9DA5E180865AC for ; Wed, 13 Oct 2021 06:59:32 +0000 (UTC) X-FDA: 78690513384.14.A33070A Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 4B8F4F0000AF for ; Wed, 13 Oct 2021 06:59:32 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id na16-20020a17090b4c1000b0019f5bb661f9so1553999pjb.0 for ; Tue, 12 Oct 2021 23:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vbWxJyRJEHl/HPjM18MBc4UW86o71YsmCHifvlg0XFw=; b=FiIeotaiLZjM5LcunU4X/qzxsxhiMl3Xdcp8Hagae/2B4EU8WMw4MmFESoq+m4xoy5 1RtT3T/31PEKI2vY2Tuy0ECZWJm2gtlT1dFb4pu97SBjhfoTxL8ILyqBgYnzle8RjvnL v8B1ZGhYla9IZDDHAcvan/WtrWuHJjHO0ZOYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vbWxJyRJEHl/HPjM18MBc4UW86o71YsmCHifvlg0XFw=; b=TcnzW2QgnpSibyCqdnq8UFkRKFNdhVwGL3lQ7PztbfZV2mc6V15GkRw4jxaOuez5RB 0d03Em8nH0hniwtT7yJMpHVXeIK5JpGb3dCrJ53+20RYFQRRhRO0M4zDY+QgaxyHAG2A tRoF56Q6YYySsW+JUEitGjUClvMHm89+NIIMX/XYhW8a3G9VYyuWSngDK8xY6ae0ErgL xjPz87XXA0DaaRksqRcyVvlXlXXrCzVeE5TogpjM0q9mSe65EzD1C0oN0hXRqKsmIBnV PXT1YDA1GQUCu8WPpGXMlYERDtUyaWdA0XYRGfQPSU0Ggi4+n1NmP32DtBe4Ar6yhTpD DB8g== X-Gm-Message-State: AOAM531HSH90arAvkAfUXQgIg3KZkvVjQ03T8TWY6iYMZ5xpBWzjp8EI IWaY/Jo+jvC8SL8rEs9CIHzzMA== X-Google-Smtp-Source: ABdhPJxg04sat7HJ6MeMqkBhaVP4fUMmZ0z8e5MnK+cAmqQm529EHMPH7/ru9Ly6sAXLV57TWcF7BA== X-Received: by 2002:a17:90a:680c:: with SMTP id p12mr11265943pjj.33.1634108371296; Tue, 12 Oct 2021 23:59:31 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id nl18sm5422324pjb.3.2021.10.12.23.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 23:59:31 -0700 (PDT) Date: Tue, 12 Oct 2021 23:59:30 -0700 From: Kees Cook To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 02/10] powerpc: Rename 'funcaddr' to 'addr' in 'struct ppc64_opd_entry' Message-ID: <202110122359.6A69C54DB@keescook> References: <892715d6f05fdf6ca80cf88a51a9e55298b68c4a.1633964380.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <892715d6f05fdf6ca80cf88a51a9e55298b68c4a.1633964380.git.christophe.leroy@csgroup.eu> X-Rspamd-Queue-Id: 4B8F4F0000AF X-Stat-Signature: r71pdbgzka9wdbr8jz6kmbmc5hwbk9bn Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=FiIeotai; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.51 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam06 X-HE-Tag: 1634108372-745222 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 11, 2021 at 05:25:29PM +0200, Christophe Leroy wrote: > There are three architectures with function descriptors, try to > have common names for the address they contain in order to > refactor some functions into generic functions later. > > powerpc has 'funcaddr' > ia64 has 'ip' > parisc has 'addr' > > Vote for 'addr' and update 'struct ppc64_opd_entry' accordingly. > > Signed-off-by: Christophe Leroy Reasonable. :) Reviewed-by: Kees Cook -- Kees Cook