From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CAA5C433F5 for ; Tue, 12 Oct 2021 20:44:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E44776023F for ; Tue, 12 Oct 2021 20:44:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E44776023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 54D24940008; Tue, 12 Oct 2021 16:44:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FC826B0071; Tue, 12 Oct 2021 16:44:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EB0F940008; Tue, 12 Oct 2021 16:44:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 30E166B006C for ; Tue, 12 Oct 2021 16:44:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E0D8F2C5AE for ; Tue, 12 Oct 2021 20:44:13 +0000 (UTC) X-FDA: 78688962786.22.19318BC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP id 80BCCD037984 for ; Tue, 12 Oct 2021 20:44:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DCA460E09; Tue, 12 Oct 2021 20:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634071451; bh=UOkTy92XzuCtUq8OKvsR+eNtXmbw0VxKGgOP+U8fxCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dVY6saMQJHCva5gnZHW+oNKn5KwkmHfFZvnbQUROIgps+NAUt0Tnuj+AqsHJKGtfH 3fHCTg5zhTRFQBkE9DaPyIvLq6BgZgb8SXieAuio3g+RKCNgXkgj2AWekbStG3HwQO r73rCEMYuTl8wf6CXc8IiMyvMrwhuH6CgKQ+huUJhcN/Cd4ktmC/prwq5eZL1v+ETb IsvtcWhHGrY9FzkjvlwajnHPvRPZeA42AML/j40oo9r6dOSZcDR8bpbC4byAHmVUWD m/NklUM8bXYUZEkRRenKS/x7vwBaC5D6GLTajdI2rjR8bYJGchfnXx2irIqrJjqJN9 pi/uIraLvn+lw== Date: Tue, 12 Oct 2021 13:44:10 -0700 From: "Darrick J. Wong" To: Felix Kuehling Cc: Matthew Wilcox , Andrew Morton , Alex Sierra , linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, apopple@nvidia.com Subject: Re: [PATCH v1 00/12] MEMORY_DEVICE_COHERENT for CPU-accessible coherent device memory Message-ID: <20211012204410.GR24307@magnolia> References: <20211012171247.2861-1-alex.sierra@amd.com> <20211012113957.53f05928dd60f3686331fede@linux-foundation.org> <1bcea911-58c6-c730-35b2-e8f1f8eddcd8@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1bcea911-58c6-c730-35b2-e8f1f8eddcd8@amd.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 80BCCD037984 X-Stat-Signature: z1hahsufitixaka6813e3zunqes3uext Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dVY6saMQ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org X-HE-Tag: 1634071453-280929 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 04:24:25PM -0400, Felix Kuehling wrote: >=20 > Am 2021-10-12 um 3:11 p.m. schrieb Matthew Wilcox: > > On Tue, Oct 12, 2021 at 11:39:57AM -0700, Andrew Morton wrote: > >> Because I must ask: if this feature is for one single computer which > >> presumably has a custom kernel, why add it to mainline Linux? > > I think in particular patch 2 deserves to be merged because it remove= s > > a ton of cruft from every call to put_page() (at least if you're usin= g > > a distro config). It makes me nervous, but I think it's the right > > thing to do. It may well need more fixups after it has been merged, > > but that's life. >=20 > Maybe we should split the first two patches into a separate series, and > get it merged first, while the more controversial stuff is still under > review? Yes, please. I've seen that first patch several times already. :) --D > Thanks, > =A0 Felix >=20 >=20