From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44616C433F5 for ; Tue, 12 Oct 2021 20:43:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E40EB60E0C for ; Tue, 12 Oct 2021 20:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E40EB60E0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 83316940007; Tue, 12 Oct 2021 16:43:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E3D76B0071; Tue, 12 Oct 2021 16:43:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AB0D940007; Tue, 12 Oct 2021 16:43:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 5D54C6B006C for ; Tue, 12 Oct 2021 16:43:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E4F71818FCF0 for ; Tue, 12 Oct 2021 20:43:47 +0000 (UTC) X-FDA: 78688961694.26.E5CE6DE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id B2467801A88D for ; Tue, 12 Oct 2021 20:43:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CA12260E09; Tue, 12 Oct 2021 20:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634071425; bh=q61LoQrLGHHMBvmawEYfkt6DnUrNORR1prK1fiM18ZA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uEThPiosyyrbJ4oy20wf2VLQNoPPVJxrr7w8jRKgrJSKn2ukj1kohMQza/+0d2pO6 yRlD2jC0/EsF1SWAMF48Ki40jtsW7eaR636VJgs0TZx2XM9ppxGfdvjPJ+WX9I0hkX Xrl9rq7ZnGE0t7KObzY2eQXdnfvyvIgJrMI8WsnbEgYh0DOSokYebdUXO9iCTiZo1h 8rD2jFMIJiQois0naFz2COeKuhTPyem/pK5xhXlMqJixUPECLB1P5smrct/KJxbCYT pNrCAC3uZzAhusWCSxT8zpVXHk8teiGxxkqt7mgQ74BqK7N2NVtg2gVWvlfQJ2l/Rd rGwbXgqgNuHsA== Date: Tue, 12 Oct 2021 13:43:45 -0700 From: "Darrick J. Wong" To: David Rientjes Cc: Rustam Kovhaev , Vlastimil Babka , Dave Chinner , linux-xfs@vger.kernel.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, gregkh@linuxfoundation.org, Al Viro , dvyukov@google.com Subject: Re: [PATCH] xfs: use kmem_cache_free() for kmem_cache objects Message-ID: <20211012204345.GQ24307@magnolia> References: <20210929212347.1139666-1-rkovhaev@gmail.com> <20210930044202.GP2361455@dread.disaster.area> <17f537b3-e2eb-5d0a-1465-20f3d3c960e2@suse.cz> <1e0df91-556e-cee5-76f7-285d28fe31@google.com> <20211012204320.GP24307@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012204320.GP24307@magnolia> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B2467801A88D X-Stat-Signature: bzducfkmdaa7gyxfkm951muuran4df6c Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uEThPios; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org X-HE-Tag: 1634071426-273860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 01:43:20PM -0700, Darrick J. Wong wrote: > On Sun, Oct 03, 2021 at 06:07:20PM -0700, David Rientjes wrote: > > On Thu, 30 Sep 2021, Rustam Kovhaev wrote: > > > > > > >> I think it's fair if something like XFS (not meant for tiny systems AFAIK?) > > > > >> excludes SLOB (meant for tiny systems). Clearly nobody tried to use these > > > > >> two together last 5 years anyway. > > > > > > > > > > +1 for adding Kconfig option, it seems like some things are not meant to > > > > > be together. > > > > > > > > But if we patch SLOB, we won't need it. > > > > > > OK, so we consider XFS on SLOB a supported configuration that might be > > > used and should be tested. > > > I'll look into maybe adding a config with CONFIG_SLOB and CONFIG_XFS_FS > > > to syzbot. > > > > > > It seems that we need to patch SLOB anyway, because any other code can > > > hit the very same issue. > > > > > > > It's probably best to introduce both (SLOB fix and Kconfig change for > > XFS), at least in the interim because the combo of XFS and SLOB could be > > broken in other ways. If syzbot doesn't complain with a patched kernel to > > allow SLOB to be used with XFS, then we could potentially allow them to be > > used together. > > > > (I'm not sure that this freeing issue is the *only* thing that is broken, > > nor that we have sufficient information to make that determination right > > now..) > > I audited the entire xfs (kernel) codebase and didn't find any other > usage errors. Thanks for the patch; I'll apply it to for-next. Also, the obligatory Reviewed-by: Darrick J. Wong --D > > --D