linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Petr Mladek <pmladek@suse.com>,
	linux-mm@kvack.org, Vlastimil Babka <vbabka@suse.cz>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH 2/5] test_printf: Assign all flags to page_flags
Date: Tue, 12 Oct 2021 19:26:44 +0100	[thread overview]
Message-ID: <20211012182647.1605095-3-willy@infradead.org> (raw)
In-Reply-To: <20211012182647.1605095-1-willy@infradead.org>

Even unknown flags should be passed to %pGp so that we can test what it
does with them (today: nothing).

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 lib/test_printf.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/test_printf.c b/lib/test_printf.c
index a52c1c3a55ba..f744b0498672 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -608,14 +608,12 @@ page_flags_test(int section, int node, int zone, int last_cpupid,
 		int kasan_tag, int flags, const char *name, char *cmp_buf)
 {
 	unsigned long values[] = {section, node, zone, last_cpupid, kasan_tag};
-	unsigned long page_flags = 0;
+	unsigned long page_flags = flags;
 	unsigned long size = 0;
 	bool append = false;
 	int i;
 
-	flags &= PAGEFLAGS_MASK;
-	if (flags) {
-		page_flags |= flags;
+	if (flags & PAGEFLAGS_MASK) {
 		snprintf(cmp_buf + size, BUF_SIZE - size, "%s", name);
 		size = strlen(cmp_buf);
 #if SECTIONS_WIDTH || NODES_WIDTH || ZONES_WIDTH || \
-- 
2.32.0



  parent reply	other threads:[~2021-10-12 18:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 18:26 [PATCH 0/5] Improvements to %pGp Matthew Wilcox (Oracle)
2021-10-12 18:26 ` [PATCH 1/5] test_printf: Make pft array const Matthew Wilcox (Oracle)
2021-10-13  5:20   ` Yafang Shao
2021-10-15  9:21   ` Petr Mladek
2021-10-18  5:32   ` Anshuman Khandual
2021-10-12 18:26 ` Matthew Wilcox (Oracle) [this message]
2021-10-13  5:20   ` [PATCH 2/5] test_printf: Assign all flags to page_flags Yafang Shao
2021-10-13  9:25   ` Kirill A. Shutemov
2021-10-15 10:22     ` Petr Mladek
2021-10-18  5:33     ` Anshuman Khandual
2021-10-15 10:14   ` Petr Mladek
2021-10-12 18:26 ` [PATCH 3/5] test_printf: Remove custom appending of '|' Matthew Wilcox (Oracle)
2021-10-13  5:21   ` Yafang Shao
2021-10-15 10:23     ` Petr Mladek
2021-10-18  5:41   ` Anshuman Khandual
2021-10-12 18:26 ` [PATCH 4/5] test_printf: Append '|' more efficiently Matthew Wilcox (Oracle)
2021-10-13  5:22   ` Yafang Shao
2021-10-13  9:27     ` Kirill A. Shutemov
2021-10-18  5:42       ` Anshuman Khandual
2021-10-13  9:59     ` Rasmus Villemoes
2021-10-15 10:37       ` Petr Mladek
2021-10-12 18:26 ` [PATCH 5/5] vsprintf: Make %pGp print the hex value Matthew Wilcox (Oracle)
2021-10-13  5:24   ` Yafang Shao
2021-10-15 10:55   ` Petr Mladek
2021-10-27 11:28     ` Petr Mladek
2021-10-18  6:13   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211012182647.1605095-3-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=pmladek@suse.com \
    --cc=senozhatsky@chromium.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox