From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E44EC433F5 for ; Tue, 12 Oct 2021 07:11:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0CE51610A4 for ; Tue, 12 Oct 2021 07:11:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CE51610A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AE3316B0071; Tue, 12 Oct 2021 03:11:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A92F16B0073; Tue, 12 Oct 2021 03:11:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A9666B0074; Tue, 12 Oct 2021 03:11:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 8C79C6B0071 for ; Tue, 12 Oct 2021 03:11:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4B9822D3B4 for ; Tue, 12 Oct 2021 07:11:23 +0000 (UTC) X-FDA: 78686914446.18.3B87202 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id F3BBFB002EE7 for ; Tue, 12 Oct 2021 07:11:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9D3F961078; Tue, 12 Oct 2021 07:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634022682; bh=qD7SONrCv4oiHwGk10dQtz0fdhOVBKUUsBL/etLiZb4=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=hdnrQmFf6/9HbBaYnMBNbTgWgQuJmo52lH2FT9VuxHVRt6FO4bz3dn0jlR/oUfWF/ gNP4vrzLKYDAH6c7Csg6nZaXHga9GQPz29/H/u9tjDa0Ayo9Ic+4SEckYr3AQFU//9 xDAyQ18km4BFPlFRFDMnJrP0qqdg4bgejhD8L2nNqjUpBeYeWm5xC5zIZNF233936O r3zIFfsSxDHltK2mZADsGadIpKMdrGtMQdl1nV8sq41xL2Bm3ONtbWnu7oW6Fw3+mS vYBWzDfRi/gEWsZuuomE3J6ctZIecPKw8vpHzlIXGRWYmgobiEIJVVG0sbGh+TdAgT 2/otWTLAchRQg== From: SeongJae Park To: Xin Hao Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/dbgfs: add region_stat interface Date: Tue, 12 Oct 2021 07:11:19 +0000 Message-Id: <20211012071119.32320-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211012054948.90381-1-xhao@linux.alibaba.com> Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hdnrQmFf; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F3BBFB002EE7 X-Stat-Signature: 4wtbixokcrh163h5dxabcrb87f87894z X-HE-Tag: 1634022682-325053 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Xin, thank you for this patch! On Tue, 12 Oct 2021 13:49:48 +0800 Xin Hao wrote: > Using damon-dbgfs has brought great convenience to user-mode > operation damon, but sometimes if i want to be able to view > the division of task regions, nr_access values etc,but i found > that it is impossible to view directly through the dbgfs interface, > so there i add a interface "region_stat", it displays like this. > > # cat region_stat > last_aggregation=120.87s > target_id=5148 > nr_regions=10 > 400000-258c000(34352 KiB): 1 > 258c000-4719000(34356 KiB): 0 > 4719000-abbf000(103064 KiB): 0 > abbf000-c4d4000(25684 KiB): 11 > c4d4000-ff5c000(59936 KiB): 15 > ff5c000-152f9000(85620 KiB): 20 > 152f9000-1599e000(6804 KiB): 10 > 1599e000-19573000(61268 KiB): 0 > 19573000-1f92c000(102116 KiB): 0 > 1f92c000-22a4c000(50304 KiB): 0 I think similar information could also be collected via the 'damon_aggregated' tracepoint[1], which is merged in the mainline, or 'DAMOS_STAT'[2], which is merged in -mm. The recording feature[3] could also be used, though it would take some time before it is merged in the mainline. Have you considered using those but found some problem? [1] https://git.kernel.org/torvalds/c/2fcb93629ad8 [2] https://lore.kernel.org/linux-mm/20211001125604.29660-6-sj@kernel.org/ [3] https://lore.kernel.org/linux-mm/20211008094509.16179-1-sj@kernel.org/ Thanks, SJ [...]