From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559C1C433F5 for ; Mon, 11 Oct 2021 02:59:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B6826054F for ; Mon, 11 Oct 2021 02:59:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B6826054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3325C6B006C; Sun, 10 Oct 2021 22:59:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E021900002; Sun, 10 Oct 2021 22:59:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6126B0072; Sun, 10 Oct 2021 22:59:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 111866B006C for ; Sun, 10 Oct 2021 22:59:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A9D922FDE1 for ; Mon, 11 Oct 2021 02:59:41 +0000 (UTC) X-FDA: 78682651362.12.3EC57C9 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP id 37ECF30008FD for ; Mon, 11 Oct 2021 02:59:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 93D666054F; Mon, 11 Oct 2021 02:59:38 +0000 (UTC) Date: Sun, 10 Oct 2021 22:59:36 -0400 From: Steven Rostedt To: Gang Li Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS Message-ID: <20211010225936.2f97d165@oasis.local.home> In-Reply-To: <20211011021124.86248-1-ligang.bdlg@bytedance.com> References: <20211011021124.86248-1-ligang.bdlg@bytedance.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 37ECF30008FD X-Stat-Signature: 9kof4rx4xsi5wdq9iyxqtw5bwhmnn531 Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=DHMc=O7=goodmis.org=rostedt@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=DHMc=O7=goodmis.org=rostedt@kernel.org" X-HE-Tag: 1633921181-617584 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 11 Oct 2021 10:11:24 +0800 Gang Li wrote: > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > > By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot > of space from duplicate code. Why did you send this? It should be two patches, not one. The rule is, every commit does one thing. Now you made this patch do two. Andrew already pulled in the other two patches. I don't think this one is appropriate, and should be discarded. -- Steve > > Signed-off-by: Gang Li