From: Steven Rostedt <rostedt@goodmis.org>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz,
axelrasmussen@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS
Date: Sun, 10 Oct 2021 22:59:36 -0400 [thread overview]
Message-ID: <20211010225936.2f97d165@oasis.local.home> (raw)
In-Reply-To: <20211011021124.86248-1-ligang.bdlg@bytedance.com>
On Mon, 11 Oct 2021 10:11:24 +0800
Gang Li <ligang.bdlg@bytedance.com> wrote:
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot
> of space from duplicate code.
Why did you send this? It should be two patches, not one. The rule is,
every commit does one thing. Now you made this patch do two.
Andrew already pulled in the other two patches. I don't think this one
is appropriate, and should be discarded.
-- Steve
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
next prev parent reply other threads:[~2021-10-11 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 2:11 Gang Li
2021-10-11 2:59 ` Steven Rostedt [this message]
2021-10-11 5:53 ` Gang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010225936.2f97d165@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox