From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546AAC433F5 for ; Sun, 10 Oct 2021 21:49:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D4C3560FBF for ; Sun, 10 Oct 2021 21:49:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D4C3560FBF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3C722900002; Sun, 10 Oct 2021 17:49:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3504C6B0072; Sun, 10 Oct 2021 17:49:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 217C1900002; Sun, 10 Oct 2021 17:49:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 0D3256B006C for ; Sun, 10 Oct 2021 17:49:41 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BC31C181AEF1F for ; Sun, 10 Oct 2021 21:49:40 +0000 (UTC) X-FDA: 78681870120.31.DC527DD Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP id 771C9300253A for ; Sun, 10 Oct 2021 21:49:40 +0000 (UTC) Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD83F60F46; Sun, 10 Oct 2021 21:49:38 +0000 (UTC) Date: Sun, 10 Oct 2021 17:49:37 -0400 From: Steven Rostedt To: Gang Li Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/2] mm: mmap_lock: use DECLARE_EVENT_CLASS and DEFINE_EVENT_FN Message-ID: <20211010174937.600a44b2@rorschach.local.home> In-Reply-To: <20211009071243.70286-1-ligang.bdlg@bytedance.com> References: <20211009071243.70286-1-ligang.bdlg@bytedance.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of "SRS0=8qKb=O6=goodmis.org=rostedt@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=8qKb=O6=goodmis.org=rostedt@kernel.org" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 771C9300253A X-Stat-Signature: 6dxgfhwrob5kxtb5jzy5kqp948ifoyzb X-HE-Tag: 1633902580-282225 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 9 Oct 2021 15:12:43 +0800 Gang Li wrote: > By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot > of space from duplicate code. Thanks for doing this. Looking at the events, they can certainly be merged into one. Reviewed-by: Steven Rostedt (VMware) -- Steve > > Signed-off-by: Gang Li