From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302C2C433FE for ; Fri, 8 Oct 2021 21:13:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE6C9610E5 for ; Fri, 8 Oct 2021 21:13:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE6C9610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 32EF86B0071; Fri, 8 Oct 2021 17:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DEE26B0072; Fri, 8 Oct 2021 17:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A6D1900002; Fri, 8 Oct 2021 17:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 0BF7A6B0071 for ; Fri, 8 Oct 2021 17:13:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ADC2F8249980 for ; Fri, 8 Oct 2021 21:13:12 +0000 (UTC) X-FDA: 78674520624.24.8F8D4B6 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf07.hostedemail.com (Postfix) with ESMTP id 6146910004C8 for ; Fri, 8 Oct 2021 21:13:12 +0000 (UTC) Received: by mail-pj1-f53.google.com with SMTP id k23so8548335pji.0 for ; Fri, 08 Oct 2021 14:13:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F0j9Fen+aM1yxtAVTmt6zwsss9sN5UsLCk44GHH1tRc=; b=I+McrbgmDL8gZ9vmtX1aR7+zkzhDrlHhXT6iEzjY4OCKkruLZDBi+tzb3viHWvPBBY kW2Us4im1MyQTWLJHDidgCouWJsWR1fzIwUGgK8+FBItkM6TWjIfpDSi5vv4VKXHDqoI OyfVYPUddfURQDYvCN/P/GevbyB1QLdePw59Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F0j9Fen+aM1yxtAVTmt6zwsss9sN5UsLCk44GHH1tRc=; b=xlJZRUEEp6ymuQHF8udpKXPh4kDTSzrnwzcN5J+OczoR5VPWKcYUEPI95hzLVmGUjr MXPmao36xe+4Gbg39zEW97MuYaOLKzFdDfW4tsbKb1nUd6sHek0g1RGFKPSrfbFl1zDd 3nt/KggQ7qWPmQKlfKjTB7Yi0fbt0Cmf2CqcaH/yTC1CTqjymGAfbdRGxBMs4MsTYL8Z ZJTOT2gArxYQN9poSGzvF+v3xp499r08QTS66DHfZXt39BEln+cuazqz5JW0zfONUYEO lLKQ3VAl+u+ie/PYduDp40xDUMEmhw8k2hOWy9Ru1uhqEbXDMlsNSnA91WXKhFVIsFsM VYuw== X-Gm-Message-State: AOAM533tGHUxjkuyg0m0V/tf4oKNKYiS9WyQDnZ7bhsVMraPb1RyEmfR /dz6XCwVuRSA4+zbhUWKvuz97A== X-Google-Smtp-Source: ABdhPJzKqh8cplGZb7R2umhTGHifh9Yt7Lk84Rr0o+/sxMRQibhJwMtOnRqKr/aL33Vlwtg7KQQOpQ== X-Received: by 2002:a17:902:7043:b0:13e:1007:3d6d with SMTP id h3-20020a170902704300b0013e10073d6dmr11395704plt.79.1633727591177; Fri, 08 Oct 2021 14:13:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x7sm233598pfj.28.2021.10.08.14.13.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 14:13:10 -0700 (PDT) Date: Fri, 8 Oct 2021 14:13:09 -0700 From: Kees Cook To: David Hildenbrand Cc: Rasmus Villemoes , John Hubbard , Suren Baghdasaryan , Michal Hocko , Pavel Machek , Andrew Morton , Colin Cross , Sumit Semwal , Dave Hansen , Matthew Wilcox , "Kirill A . Shutemov" , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Al Viro , Randy Dunlap , Kalesh Singh , Peter Xu , rppt@kernel.org, Peter Zijlstra , Catalin Marinas , vincenzo.frascino@arm.com, Chinwen Chang =?utf-8?B?KOW8temMpuaWhyk=?= , Axel Rasmussen , Andrea Arcangeli , Jann Horn , apopple@nvidia.com, Yu Zhao , Will Deacon , fenghua.yu@intel.com, thunder.leizhen@huawei.com, Hugh Dickins , feng.tang@intel.com, Jason Gunthorpe , Roman Gushchin , Thomas Gleixner , krisman@collabora.com, Chris Hyser , Peter Collingbourne , "Eric W. Biederman" , Jens Axboe , legion@kernel.org, Rolf Eike Beer , Cyrill Gorcunov , Muchun Song , Viresh Kumar , Thomas Cedeno , sashal@kernel.org, cxfcosmos@gmail.com, LKML , linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm , kernel-team Subject: Re: [PATCH v10 3/3] mm: add anonymous vma name refcounting Message-ID: <202110081401.7AB25E4@keescook> References: <202110071111.DF87B4EE3@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6146910004C8 X-Stat-Signature: wr1jhq8dww5pkjnr81c9mndpddmab18c Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=I+Mcrbgm; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.53 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1633727592-416491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 08, 2021 at 09:43:59AM +0200, David Hildenbrand wrote: > I'm going to point out that we already do have names for memfds. I just did the same here[1]. :P > [...] It's also displayed in /proc/self/maps. I missed that part! /me screams forever We really need to filter this at creation time. :( At least seq_file_path() escapes "\n" for it, but not "\r", so humans on a terminal could get very confused... $ ./memfd '^M0000000000000000-ffffffffffffffff rwxp 00000000 00:00 0 [stack]' & [1] 2953833 $ cat /proc/2953833/maps ... 0000000000000000-ffffffffffffffff rwxp 00000000 00:00 0 [stack] (deleted) ... -Kees [1] https://lore.kernel.org/lkml/202110081344.FE6A7A82@keescook -- Kees Cook