From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B4BC433FE for ; Wed, 6 Oct 2021 19:08:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A437461175 for ; Wed, 6 Oct 2021 19:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A437461175 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 058136B006C; Wed, 6 Oct 2021 15:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00831900002; Wed, 6 Oct 2021 15:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5FCB6B0073; Wed, 6 Oct 2021 15:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id D7A0F6B006C for ; Wed, 6 Oct 2021 15:08:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8957D39493 for ; Wed, 6 Oct 2021 19:08:14 +0000 (UTC) X-FDA: 78666948108.10.98194E9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 2A13C90000BA for ; Wed, 6 Oct 2021 19:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633547293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D1dm0Jsv2mUc+jhdc8qHClKIoNz3UWNx693+PgEldu0=; b=Kp6Lp6F6BO229r0V4UqRUD2mSGRW+MPP2ygPi8ArgGskQbOxQqgV1krmAYzZPDwEeXcf4u ZvitvmsGOVEa4zlMF4o9N0wbUyzcKFdRSbu16Bm/uzvs99sp2el54HJMN/c5W5WmlkHfKh H9Pga+vsMMRP8EQ/RCJz7uz8J5BLmPI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-S7ezdSSWOCqja-S-sRLYzw-1; Wed, 06 Oct 2021 15:08:12 -0400 X-MC-Unique: S7ezdSSWOCqja-S-sRLYzw-1 Received: by mail-wr1-f71.google.com with SMTP id d13-20020adfa34d000000b00160aa1cc5f1so2814035wrb.14 for ; Wed, 06 Oct 2021 12:08:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=D1dm0Jsv2mUc+jhdc8qHClKIoNz3UWNx693+PgEldu0=; b=pXmowQx7qSFoWWmg2/vWEpxMmPbt5J7myYBe2oYl3+Hg1PytUuCoOX6+GKx1V8lkFE X21zdFEcr2uyJAW9CuAgZF1B8zl2frBZVm8DgKFFCz0NDlD7ZF4JczzHC4j5Kk4BOCdk LP5Zu5iW/cxIxCsnedWIS+1gm+ktgpTIMH5BzE4IaLWf6b9JpMgCKwnejeBWS7QGN4FW Ugb3erBFc68Mza0BQWuKc/q41dFefY2iPxceqd0LMlwVKm0UVWtJQUVU8jbIGHQiDJOY KArW0VYbfEqNO0WkgBvl5sRVSwbqJqzKaYErtbh1J+muuWmc3rSsE875MGmyhH0JjRoF o3JQ== X-Gm-Message-State: AOAM532ZBDBE1oAxR6NSsAm4oKqpCdIfkC/Ql2zi23XYrGBIJGbYjNhl c0KaxPlXG5iXVsiJV3OvbAusyfeufmMo0EWccaelUIH7dW7X2PKbI/UHbP5SjK4u4guhoIaQO7+ q4EM9vmcOOg== X-Received: by 2002:a7b:c7ca:: with SMTP id z10mr26840wmk.143.1633547291500; Wed, 06 Oct 2021 12:08:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzW3Vplh1TB3mapUwuNjmaCci2ywucaNaPkBXKlNFfA0xxJLgQjy0Of/3AUsfgwnuRUSg9LQQ== X-Received: by 2002:a7b:c7ca:: with SMTP id z10mr26813wmk.143.1633547291261; Wed, 06 Oct 2021 12:08:11 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id s186sm7171134wme.14.2021.10.06.12.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 12:08:10 -0700 (PDT) Date: Wed, 6 Oct 2021 20:08:10 +0100 From: Aaron Tomlin To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Muchun Song Subject: Re: [PATCH v2] mm/memcg: Remove obsolete memcg_free_kmem() Message-ID: <20211006190810.ume55n4lugekcm63@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20211005202450.11775-1-longman@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211005202450.11775-1-longman@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2A13C90000BA X-Stat-Signature: 7pg59o19d4wcftho69mwggyijgr1mbwe Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Kp6Lp6F6; spf=none (imf28.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1633547294-27607 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 2021-10-05 16:24 -0400, Waiman Long wrote: > Since commit d648bcc7fe65 ("mm: kmem: make memcg_kmem_enabled() > irreversible"), the only thing memcg_free_kmem() does is to call > memcg_offline_kmem() when the memcg is still online which can happen when > online_css() fails due to -ENOMEM. However, the name memcg_free_kmem() > is confusing and it is more clear and straight forward to call > memcg_offline_kmem() directly from mem_cgroup_css_free(). > > Suggested-by: Roman Gushchin > Signed-off-by: Waiman Long Reviewed-by: Aaron Tomlin -- Aaron Tomlin