From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 978BEC433F5 for ; Wed, 6 Oct 2021 04:00:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20CB861260 for ; Wed, 6 Oct 2021 04:00:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 20CB861260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A54FD6B006C; Wed, 6 Oct 2021 00:00:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0476900002; Wed, 6 Oct 2021 00:00:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CC746B0073; Wed, 6 Oct 2021 00:00:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 814E46B006C for ; Wed, 6 Oct 2021 00:00:29 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3C0218249980 for ; Wed, 6 Oct 2021 04:00:29 +0000 (UTC) X-FDA: 78664660578.07.BAD8571 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by imf25.hostedemail.com (Postfix) with ESMTP id BDE72B001783 for ; Wed, 6 Oct 2021 04:00:28 +0000 (UTC) Date: Wed, 6 Oct 2021 13:00:15 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1633492826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j4OHhLztgaT2DVmS+ewtyxjius1Brkr/mlfv76zVtN4=; b=iWRB+sjLt42EFg/TfR10HXvMvWAmSvLHHydjIBK8hIHMExaZjoVZDB1dvRUiqebhLQ1jJO /FfCX7CdurW2Gt4CzPZQuXAhCFXIpCtcdwy31S64cxy7QRnfSarXs52dVwI1MrStFibusU uugiI+MicVeX3tHZ+jYxj0vXfbDcCSg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Yang Shi Cc: naoya.horiguchi@nec.com, Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Peter Xu , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Subject: Re: [v3 PATCH 1/5] mm: hwpoison: remove the unnecessary THP check Message-ID: <20211006040015.GA1626563@u2004> References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-2-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: naoya.horiguchi@linux.dev X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BDE72B001783 X-Stat-Signature: 95q7st7dt96mczdu76qe3i8o8f4tsa4e Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iWRB+sjL; spf=pass (imf25.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 94.23.1.103 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-HE-Tag: 1633492828-482963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Any comment on this patch and patch #3? I'd prefer to fix more > comments for a new version. No. Both 1/5 and 3/5 look fine to me. So ... > On Thu, Sep 30, 2021 at 2:53 PM Yang Shi wrote: > > > > When handling THP hwpoison checked if the THP is in allocation or free > > stage since hwpoison may mistreat it as hugetlb page. After > > commit 415c64c1453a ("mm/memory-failure: split thp earlier in memory error > > handling") the problem has been fixed, so this check is no longer > > needed. Remove it. The side effect of the removal is hwpoison may > > report unsplit THP instead of unknown error for shmem THP. It seems not > > like a big deal. > > > > The following patch depends on this, which fixes shmem THP with > > hwpoisoned subpage(s) are mapped PMD wrongly. So this patch needs to be > > backported to -stable as well. > > > > Cc: > > Suggested-by: Naoya Horiguchi > > Signed-off-by: Yang Shi Acked-by: Naoya Horiguchi Patch 3/5 already has my Signed-off-by, so I think it can be considered as acked by me. Thanks, Naoya Horiguchi