From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] is SLAB considered legacy and deprecated?
Date: Tue, 5 Oct 2021 13:31:02 +0000 [thread overview]
Message-ID: <20211005133102.GB2760@kvm.asia-northeast3-a.c.our-ratio-313919.internal> (raw)
In-Reply-To: <075fde61-8c28-25ec-0ec1-28b1bdea7c95@suse.cz>
On Mon, Oct 04, 2021 at 01:39:46PM +0200, Vlastimil Babka wrote:
> On 10/4/21 08:01, Hyeonggon Yoo wrote:
> > On Sun, Oct 03, 2021 at 06:25:29PM -0700, David Rientjes wrote:
> >> I would disagree that SLAB isn't currently maintained, I think it's
> >> actively maintained.
> >
> > I thought it was not actively maintained because most of patches were
> > fixups and cleanups for years and as Vlastimil said, new features are
>
> Fixups and cleanups still count as "actively maintained". The opposite
> case would be "nobody uses it because it was broken for years since
> commit X and we only noticed now".
>
Yup, there seems I was differently using meaning of "actively
maintained".
> > only added to SLUB. development was focused on SLUB.
> >
> >> I think the general guidance is that changes for both allocators can still
> >> be merged upstream if they show a significant win (improved performnace,
> >> maintaining performance while reducing memory footprint, code hygiene,
> >> etc) and there's no specific policy that we cannot make changes to
> >> mm/slab.c.
> >
> > Good.
> >
> > I see things to improve in SLAB and want to improve it.
> > I will appreciate if you review them.
>
> It would be great if your motivation started with "I prefer SLAB over
> SLUB because X and Y but I need to improve Z", not just a theoretical
> concern.
>
Thank you for advice. by making dumb patches I realized that
, yeah, just a theoretical concern does not help.
I should have more understanding on internals of slab allocators
and on how their characteristics affect performance depending on situation.
and most importantly I should have actual evidence of performance measurement.
I'm sorry and Thank you for thinking about and answering my (somewhat dumb) questions.
But I'm happy that I'm learning a lot from your feedback.
> > Thanks,
> > Hyeonggon
> >
>
next prev parent reply other threads:[~2021-10-05 13:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 9:03 Hyeonggon Yoo
2021-09-27 17:03 ` Vlastimil Babka
2021-09-28 11:12 ` Hyeonggon Yoo
2021-09-29 10:50 ` Hyeonggon Yoo
2021-10-01 14:07 ` Vlastimil Babka
2021-10-03 5:59 ` Hyeonggon Yoo
2021-10-04 1:25 ` David Rientjes
2021-10-04 6:01 ` Hyeonggon Yoo
2021-10-04 11:39 ` Vlastimil Babka
2021-10-05 13:31 ` Hyeonggon Yoo [this message]
2021-10-04 11:34 ` Vlastimil Babka
2021-10-04 14:22 ` Hyeonggon Yoo
2021-10-01 0:39 ` Queueing is outside of SLUB nowdays Hyeonggon Yoo
2021-10-04 14:56 ` Christoph Lameter
2021-10-05 8:19 ` Vlastimil Babka
2021-10-05 14:16 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005133102.GB2760@kvm.asia-northeast3-a.c.our-ratio-313919.internal \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox