From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8723DC433F5 for ; Mon, 4 Oct 2021 14:06:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2ADFD6124F for ; Mon, 4 Oct 2021 14:06:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2ADFD6124F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C5F6C940027; Mon, 4 Oct 2021 10:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0F7894000B; Mon, 4 Oct 2021 10:06:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFEC8940027; Mon, 4 Oct 2021 10:06:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0068.hostedemail.com [216.40.44.68]) by kanga.kvack.org (Postfix) with ESMTP id A130194000B for ; Mon, 4 Oct 2021 10:06:48 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 63BB9250C2 for ; Mon, 4 Oct 2021 14:06:48 +0000 (UTC) X-FDA: 78658930896.12.B5D7188 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf09.hostedemail.com (Postfix) with ESMTP id EF05A3002E7C for ; Mon, 4 Oct 2021 14:06:47 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id e15so72151406lfr.10 for ; Mon, 04 Oct 2021 07:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=I5iiIUW34DuiTSF34m8K0qNYgofVcVIOCi6xjuMFs7U=; b=3kKfkFlAkxuo4h6f/0sKIcUascSJ1EjVtDaSc8mCz0mj2hiSUImHVOKBixi4ZXJ1Zh nf3oKrJdV0S6Pjxbj5UOnRW+JUK37P29cFNoWpwkY+ELXLvLY3QOPFyCiQplYH+7NyR/ 7KDIsN0v0grmhqRZG0V+albGTp7C+A6aWp7F/Q7Nmv1l3SbrOr/YadY2efvoa0d7RoN3 l9YCobpIhuudY2yGYUZgUxKeH4qrJ5IZ66fthZ2U1uASotK3VM9ZQqVGVkAymap7Vt0v se3xf6LlY331tb9U4q7FskeOEe46Hq3Gc6YXaTeoHVyURSV5iY32K76etywNbvy/qCIv mQUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I5iiIUW34DuiTSF34m8K0qNYgofVcVIOCi6xjuMFs7U=; b=MAkeUTsJWRmtepapBTjmg5EQqezvYqv1iqs14lX0ezAcKd1kRxiIdOM6tVqwbBlZB/ LVnxIAcnaoeuy9iWPDQlhL+fgsjfYByPF+F3zEaMNL9Fwe6K7gsfX1Q6p874cIWxUCd2 /oW8Spzceg576KNdZDYTvLe4ssK0BpIwaDDIDqOnqjhBUnkPoVY1S/elS0oq4RC3R+sa /OxyBeNL4Xho/HmvGoGTo7Qq4PLIA0kIHPUpa/YZnpGxeFoKE4scdoHpQwyNG8jrb+h2 Nz/JL0DWFVq6WeQdAT2YYLw38TKnKfa5Ss1N3GvaHlyDrmCJ7cwkHyZNyZdK5gDXDJqm ouBA== X-Gm-Message-State: AOAM531qhhzQeUsEDHIz84QfvzrStmMS1SoMWe0w4afhabvMeZb7ZtkN xH4je+dGCGwUrpIwb1Qck3sLkg== X-Google-Smtp-Source: ABdhPJykedCpqepvR4UG4/lr+U/Wj7wVzLKNTIYtri7nFzzWco7d85ytJzGv0IGm0ILetCdz5mkUEQ== X-Received: by 2002:a19:dc5b:: with SMTP id f27mr15017676lfj.145.1633356399534; Mon, 04 Oct 2021 07:06:39 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v27sm1770788lfp.0.2021.10.04.07.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:06:38 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id C563710306D; Mon, 4 Oct 2021 17:06:37 +0300 (+03) Date: Mon, 4 Oct 2021 17:06:37 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, peterx@redhat.com, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Message-ID: <20211004140637.qejvenbkmrulqdno@box.shutemov.name> References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210930215311.240774-3-shy828301@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EF05A3002E7C X-Stat-Signature: 6ik6fs1rj5xp8mmsfh9f5hfsmrdupiz6 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=3kKfkFlA; dmarc=none; spf=none (imf09.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.41) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1633356407-518003 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > diff --git a/mm/filemap.c b/mm/filemap.c > index dae481293b5d..2acc2b977f66 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > } > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { > - vm_fault_t ret = do_set_pmd(vmf, page); > - if (!ret) { > - /* The page is mapped successfully, reference consumed. */ > - unlock_page(page); > - return true; > - } > + vm_fault_t ret = do_set_pmd(vmf, page); > + if (!ret) { > + /* The page is mapped successfully, reference consumed. */ > + unlock_page(page); > + return true; > + } > } > > if (pmd_none(*vmf->pmd)) { Hm. Is it unrelated whitespace fix? -- Kirill A. Shutemov