From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F6DC433EF for ; Mon, 4 Oct 2021 05:38:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45A4A60F92 for ; Mon, 4 Oct 2021 05:38:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 45A4A60F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 66AB46B006C; Mon, 4 Oct 2021 01:38:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61A8A6B0071; Mon, 4 Oct 2021 01:38:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 509F86B0072; Mon, 4 Oct 2021 01:38:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3D2966B006C for ; Mon, 4 Oct 2021 01:38:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B9B8E8249980 for ; Mon, 4 Oct 2021 05:38:07 +0000 (UTC) X-FDA: 78657649014.05.ADE7F45 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf13.hostedemail.com (Postfix) with ESMTP id 64AD01038185 for ; Mon, 4 Oct 2021 05:38:07 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id me5-20020a17090b17c500b0019af76b7bb4so3657552pjb.2 for ; Sun, 03 Oct 2021 22:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Tq0l7s5aqcsatZHITso0miQL7uKU181XjXi2aKB8ehU=; b=Zk1VBVl9gn3/Clp1c/oV/PSxJE2LF4Zh2QH1hm2MlMcrn5SsuYPw0piHD8NlcnNcnT AmE1yx1myRjmio/kMypE9oWVr6Km3lc9BDWPj7E7cEgZZQ6ZRf/UpxJG+/sjK2aSmBg2 yDzfFreydseFy6mlKpgDPXUhkl7OyM0nnvJ6haAdPB3bJghAT3OFTteQm9JesbDbd+gE zVBBuU+gOFlr+BPXA0DKkraSyzUhctSHpN8ziPMOb1SUiFsDpcv4G+vyTDHEPFwQmm/A ajtXvLyrjdor6xfQ/4F87MOSdyU5q4L7hNjChF/fAZLlreXzUlXJrSArDvxed2L1Gbew xgNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Tq0l7s5aqcsatZHITso0miQL7uKU181XjXi2aKB8ehU=; b=aFCzdOUUjPk33CPSj/IVhbzQuzp1KR7G5+H6vp7IWYvvN5cmJqCySfsF8AZF5ulmL5 Uyt7OSvV7rdJyQjFJWPLu/6k36xlwIeELrep/DCcLA/QpLvTKfuNl+yfHOn3H6gV3R6G C0tCuaSGYMDRF3RKYOijQH/UFGSEGQrqquIabEXxyrVDuwtlorB3HDOVtBBTbr7WnfCq v9Jr5nYG0K2Yg0mRonfbjgOkpi6F2Q9nlOKaJWlG9agxgv013sHheQD3kwiKt6JdD4cw GMcYG4eFvpqG7maU4AAKsRU3TiQWqQJ4XWTiQYqb8dy9GHLU5ww+2v2mBtiNS4lkCi7Q sMcQ== X-Gm-Message-State: AOAM533s8QmEJd5it3UXmhl/6r0hkBLeICp3CVpUmaKIFGp+PdKWTLqk mboRDjfw1zRiMrV6lngzpa+KtY+Fc7w= X-Google-Smtp-Source: ABdhPJyWktXlDh6Qa4SafhNJ38qGmR+NW9ts9P+y3ZqUilfW8vSLm0xpqVqhIMa1MEV1w6u9aGcuAg== X-Received: by 2002:a17:902:d707:b0:13d:bbe8:bcff with SMTP id w7-20020a170902d70700b0013dbbe8bcffmr22637156ply.75.1633325886307; Sun, 03 Oct 2021 22:38:06 -0700 (PDT) Received: from linux.asia-northeast3-a.c.our-ratio-313919.internal (252.229.64.34.bc.googleusercontent.com. [34.64.229.252]) by smtp.gmail.com with ESMTPSA id i27sm12585289pfq.184.2021.10.03.22.38.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 22:38:06 -0700 (PDT) Date: Mon, 4 Oct 2021 05:38:02 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka Subject: Re: [RFC PATCH] mm, slab: Reduce space complexity of alien_cache using rbtree Message-ID: <20211004053802.GA2575@linux.asia-northeast3-a.c.our-ratio-313919.internal> References: <20211003051750.8296-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211003051750.8296-1-42.hyeyoo@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 64AD01038185 X-Stat-Signature: qk9wkywuu455qriuqnbd49sskimeyp57 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Zk1VBVl9; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-HE-Tag: 1633325887-665804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 03, 2021 at 05:17:50AM +0000, Hyeonggon Yoo wrote: > + for (i = 0; i < alc_ptr->capacity; i++) { > + alc_ptr->pool[i] = kmalloc_node(sizeof(struct alien_object), gfp, node); > + if (!alc_ptr->pool) { There is mistake - the condition is (!alc_ptr->pool[i]). > + for (i = i - 1; i >= 0; i--) > + kfree(alc_ptr->pool[i]); > + kfree(alc_ptr->pool); > kfree(alc_ptr); > return NULL; > } > } Anyway, I want to hear other's opinions. Is this trade-off sounds affordable to you?