From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [RFC PATCH] mm, slab: Reduce space complexity of alien_cache using rbtree
Date: Mon, 4 Oct 2021 05:38:02 +0000 [thread overview]
Message-ID: <20211004053802.GA2575@linux.asia-northeast3-a.c.our-ratio-313919.internal> (raw)
In-Reply-To: <20211003051750.8296-1-42.hyeyoo@gmail.com>
On Sun, Oct 03, 2021 at 05:17:50AM +0000, Hyeonggon Yoo wrote:
> + for (i = 0; i < alc_ptr->capacity; i++) {
> + alc_ptr->pool[i] = kmalloc_node(sizeof(struct alien_object), gfp, node);
> + if (!alc_ptr->pool) {
There is mistake - the condition is (!alc_ptr->pool[i]).
> + for (i = i - 1; i >= 0; i--)
> + kfree(alc_ptr->pool[i]);
> + kfree(alc_ptr->pool);
> kfree(alc_ptr);
> return NULL;
> }
> }
Anyway, I want to hear other's opinions.
Is this trade-off sounds affordable to you?
next prev parent reply other threads:[~2021-10-04 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 5:17 Hyeonggon Yoo
2021-10-04 5:38 ` Hyeonggon Yoo [this message]
2021-10-04 14:05 ` Christoph Lameter
2021-10-05 13:18 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004053802.GA2575@linux.asia-northeast3-a.c.our-ratio-313919.internal \
--to=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox