From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0655C433F5 for ; Mon, 4 Oct 2021 03:44:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3541C61166 for ; Mon, 4 Oct 2021 03:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3541C61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 83E4D6B006C; Sun, 3 Oct 2021 23:44:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ED5A900002; Sun, 3 Oct 2021 23:44:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DCED6B0072; Sun, 3 Oct 2021 23:44:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 5A4F16B006C for ; Sun, 3 Oct 2021 23:44:51 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 01D1218041CFF for ; Mon, 4 Oct 2021 03:44:50 +0000 (UTC) X-FDA: 78657363582.15.B3789AD Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf14.hostedemail.com (Postfix) with ESMTP id A384B600733E for ; Mon, 4 Oct 2021 03:44:50 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id n2so10160240plk.12 for ; Sun, 03 Oct 2021 20:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Niqrq0J1KTVYT0myMYXWMhyJmpkyp9spREFhBg+KqDI=; b=Vs1GimwYyLGQzKtDuxp34o1WuR3R2HfwGe1WnKcDrrjDQIkOdowhDMdptbAWAMb2Am gRkMS/48iwixZC6HIVkbP9VuQBPrlQp8LwHDCfmkGJ16EFAg7pIMfBw4kyUo4btI/Fll 06hOXB4QwW2uz6bZEDAtMt2h2KN6Itlw/Z7T3opv1zdJqjvYkzRz2C0PL8hcmLHdvLku h4XzLh3wiZHlOt3OF0YI3xpESmtToKP7e4LSk9JA5A2BCXPwgwtNF9wP3X/Nbb3Cb8ee ou/YFFSsIVk9k5761cPW0m2jjLosorbWMEwzlE7FGP1UFnbtXkM0AIWtRfaJXd5uknAO O+tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Niqrq0J1KTVYT0myMYXWMhyJmpkyp9spREFhBg+KqDI=; b=dUs6wcJ85Nv+el6EJlt57QRv/DOH+luOF3FzUlzpK9GLO0GQz5B6atF9XadgFJIKUK wYAPhm8QbaLyqJgCsGEKGxNtSXmTIUnjFF6U1lbHHIvhVQieNTldM4qFvxrojB9vtinK vZHOcFgbGxqRsdLltv9NGnbkRGQTHRwZ3D7ZWYciBDrWa96lW7vCCSzygp46+zILZ/UO h0zGJhSAgoFhoa2y7rTPGeYvwMiS/wMKD2SMk/z+pheCxYeE+1CC1O7cAzPYr+NxIIvy FhceSV0OFjy/h6O1zTQFTqO6wubSRXqVU07vIl2NcA45qNbdrREISWJTAeoqfJh0EkLu QigA== X-Gm-Message-State: AOAM532xuN+oC0F45atTTxl5Wy5HO6G3wI2OQhR+nfuDilRGE75Dqraj hgMyM7dtkdsmemOBuEkhKT0= X-Google-Smtp-Source: ABdhPJyJ+W71sIbsXYWswo225VxJjwNbbyU++d7qQlnxo2gMJ4FQ/hudHyr+TQLXaH2NsH0Dk3jrJA== X-Received: by 2002:a17:90a:9f91:: with SMTP id o17mr14594834pjp.225.1633319089223; Sun, 03 Oct 2021 20:44:49 -0700 (PDT) Received: from ubuntu ([171.224.177.7]) by smtp.gmail.com with ESMTPSA id fh3sm13734240pjb.8.2021.10.03.20.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 20:44:48 -0700 (PDT) Date: Mon, 4 Oct 2021 10:44:41 +0700 From: Nghia Le To: Mike Kravetz Cc: Matthew Wilcox , akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, lukas.bulwahn@gmail.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show() Message-ID: <20211004034441.GA114074@ubuntu> References: <20211003114113.109463-1-nghialm78@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A384B600733E X-Stat-Signature: 1euzq3wg5thhpik5c5nyp17x19itmx5b Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Vs1GimwY; spf=pass (imf14.hostedemail.com: domain of nghialm78@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=nghialm78@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1633319090-405546 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 03, 2021 at 07:36:54PM -0700, Mike Kravetz wrote: > On 10/3/21 6:54 AM, Matthew Wilcox wrote: > > On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote: > >> { > >> struct hstate *h; > >> - unsigned long demote_size; > >> int nid; > >> > >> h = kobj_to_hstate(kobj, &nid); > >> - demote_size = h->demote_order; > >> > >> return sysfs_emit(buf, "%lukB\n", > >> (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K); > > > > I'd suggest this function would look better written as: > > > > int nid; > > struct hstate *h = kobj_to_hstate(kobj, &nid); > > unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K; > > > > return sysfs_emit(buf, "%lukB\n", demote_size); > > Thanks Matthew for the clean code. > > Thank you Nghia Le for spotting this, and thank you Matthew for the > suggestion. > > This is still just in Andrew's tree and subject to modification before > the next merge window. I am still expecting additional comments on the > series. > > If another version of the series is needed, I will include Matthew's > suggestion. If not, I will ask Andrew how he would prefer to fold in > the changes. > -- > Mike Kravetz Thanks Mike, so we will wait further comments from Andrew and others.