From: Nghia Le <nghialm78@gmail.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org,
nathan@kernel.org, ndesaulniers@google.com
Cc: Nghia Le <nghialm78@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, lukas.bulwahn@gmail.com,
kernel-janitors@vger.kernel.org
Subject: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show()
Date: Sun, 3 Oct 2021 18:41:13 +0700 [thread overview]
Message-ID: <20211003114113.109463-1-nghialm78@gmail.com> (raw)
The command "make clang-analyzer" detected a dead store.
Remove demote_size and corresponding assignment in function
demote_size_show() to fix dead store, as demote_size is never read.
Signed-off-by: Nghia Le <nghialm78@gmail.com>
---
mm/hugetlb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 993efa70bce4..ef00e6ad0f6a 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -3706,11 +3706,9 @@ static ssize_t demote_size_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct hstate *h;
- unsigned long demote_size;
int nid;
h = kobj_to_hstate(kobj, &nid);
- demote_size = h->demote_order;
return sysfs_emit(buf, "%lukB\n",
(unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
--
2.25.1
next reply other threads:[~2021-10-03 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 11:41 Nghia Le [this message]
2021-10-03 13:54 ` Matthew Wilcox
2021-10-04 2:36 ` Mike Kravetz
2021-10-04 3:44 ` Nghia Le
2021-10-04 22:46 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003114113.109463-1-nghialm78@gmail.com \
--to=nghialm78@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=lukas.bulwahn@gmail.com \
--cc=mike.kravetz@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox