From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 640DAC433F5 for ; Fri, 1 Oct 2021 13:23:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AB4261267 for ; Fri, 1 Oct 2021 13:23:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0AB4261267 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 770CC940109; Fri, 1 Oct 2021 09:23:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F9C9400E4; Fri, 1 Oct 2021 09:23:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C178940109; Fri, 1 Oct 2021 09:23:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 4B3C09400E4 for ; Fri, 1 Oct 2021 09:23:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0DD66180AD804 for ; Fri, 1 Oct 2021 13:23:02 +0000 (UTC) X-FDA: 78647934204.04.AAE0BD8 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf03.hostedemail.com (Postfix) with ESMTP id 866F6300398C for ; Fri, 1 Oct 2021 13:23:01 +0000 (UTC) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 191D6Z7Z019576; Fri, 1 Oct 2021 13:22:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=pVXySShPM3pbPdz/Wk/oolxBDoN534PLtkwmfBTcxI8=; b=u9XaGHzQ6o+mcLnd0ioG5BsW36+bRoquvaaA/6Cy/yUVcq0dc8Fe36iiERtkiOS7VGHI VKgqCtBwZwOX1SlQYQk+aIjjIGjz7EybG3ZQayRjWbPg7AYftBg+P1ajus59/N4daRWU S/81oGfKF144dLGrD2UwFQ9sL3hiGbKtv1n82oZWGEyYY+f5ojmNzz24xTLYHIbuk5AJ mGDPaCy9nwJrlzN05PMHD0oDn6ODHLydG6px5gJwBA9PwMA4wSJOF9QD3j98biErBPvC 07PKsBc3si+9UWjbCDtmTbLbOFLWJkNK+4Vnul00sGrcZkXDs99V1cJgk3gP5ps/jWNV ZA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3bde3cfnhe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Oct 2021 13:22:40 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 191DGYL4154232; Fri, 1 Oct 2021 13:22:34 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by userp3030.oracle.com with ESMTP id 3bc3bp6ab9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Oct 2021 13:22:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiZUsW4B41IF+IbUex+jMWy4cXjPLsy18FatmuiH4sR9uy4ajEB7ZNQzH8rO0zzmGfsmVYZgAyKeBb8yHxivFyF2+4ozjuOlPS0em2/HdtSPH6BOOMzYzmGo5Jb3yXEdQS1OGY0rZK2Y91B5OZxCSwIZgpRD24bVFnLOW4IhxGfwW7HCW8gd8LQRQwfB8ImcUTR1zICm5/ZAFnTqwNcYDHdZmdlu+S2h73G4pg1KswbIeCI67UkZ/guTdwTxfoTIV+hVQo3M6tLqxf9gqDFjPT6cLIGqq4CEUclN3SXOaiQOQwxaaDWzp/Sv3H2WJhPjvdr3+sEzj0loJOPyuKXwDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVXySShPM3pbPdz/Wk/oolxBDoN534PLtkwmfBTcxI8=; b=lJ136w9OSFZpxRkmmVwDa0a9AP2DKq/GhKUo8G9CC2AzC++UkHNAL2jcmbUrTpgTAXRdYCGg3J6k4Ys1B7ACanqWRjulrsLljYkRiAzA9VyEtBcTVA1ggCy+TNx/s/q5OdOamxiUHh5Yh9lK0wOJRNDDObE3TCuVNfXzmaZxMMMDtetQ+fWtTqWogaUibB8XxW68LZY9iEKGPDikQ/cJ7riREiGooyQlBmTec/vn6p4+N0vPZ1N1pr0T+i0yd55BZDuhTUcki6ISbI7FGjMhPR7oMEyuoBv0I/nZ5Ph+AlkAOX10M3UVlJ5IIOdfo3sUTlpbvoMuLdD02S4BP2XQKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVXySShPM3pbPdz/Wk/oolxBDoN534PLtkwmfBTcxI8=; b=bdBYtVHEsERe5XMvVx4SS8WdheEb+mTwSOxnjhYH/l/wcs37ZphXdZKu2PUG3frOxOQjgso5mmsUzZQarLLPx7gxwDmJN2Pa8yNeeYb9bRCpdrFqCc9Y6OzcYjliifecrVGWOt4B9CCGIwZ1GCVOJdAlqBgCgJaYrbhCYx8DJG4= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR10MB1424.namprd10.prod.outlook.com (2603:10b6:300:21::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15; Fri, 1 Oct 2021 13:22:32 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d409:11b5:5eb2:6be9]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d409:11b5:5eb2:6be9%5]) with mapi id 15.20.4544.025; Fri, 1 Oct 2021 13:22:32 +0000 Date: Fri, 1 Oct 2021 16:22:21 +0300 From: Dan Carpenter To: yaozhenguo1@gmail.com Cc: linux-mm@kvack.org Subject: [bug report] hugetlbfs: extend the definition of hugepages parameter to support node allocation Message-ID: <20211001132220.GA7666@kili> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::20) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 Received: from kili (62.8.83.99) by ZR0P278CA0010.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Fri, 1 Oct 2021 13:22:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0c3e8f37-f646-459d-c061-08d984de864d X-MS-TrafficTypeDiagnostic: MWHPR10MB1424: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /54oZ1zTNvkEBM+Nt6Mq4h6vLYbF0ZWNWf/7U7+SglxGg5sURB76qiXqOlNzOyhFCB9JYJulDfA9XSe0f/v53Pu9bifouwfIjhzIbUi26zMQaOjIrxxAgMsNj8yWjfTYJfbjf0+84RXUV2zWozSpjVkz+DTh/X28T7K7+0cXd/8uMGLpt341DAKVVjRLdfYtlJmhsvZHZX5as1RjAkRIqdr8RAZNiF+3BDZR7LjGn7aDgTrEumPHg901TpGA+vqQ0fE0a4NBj+Lra4OqOpE5DM9tGG5d6uTjvCKc0oWGLWiKtJbhMvGBnxYzEEvkhpgfM0RtTe5sWPe8LmbBLUH5T4UwHJ63I76H+gAxQB2TtBXGb2NeJNsNgtEHgqwtSG+n4QJV6vn9S0WWJwjQrrqeENDuwCSQeobBgzKaTK9wcRlbUeb4E75hsO/z3+cY2V2j9nHwdQp/wII2wXs9v81QYmB+gzX9c4kKE8SyuR/ntNO2Wwtd2EC42Hz/5apk980k1H0yqHasDOS10k6WSysm4X49Uj6gH5drtxWfa8WKsKpjVIPYYtH4j1idhjyUuAd9c1EoDCXg8CDrA7BFaskkY6JH8+LqUw9Qhcjgl5EgMUQeWdwjaZVD+YMh3uoWsjPeQtQvb1wMxKzC4RD0hiBWE6FQLIn+T7o+Rk8vszgz+M/vfXQjMKotKucxUw5Gm6bYzPKh7U4VAbNxQwYiu0XgiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38350700002)(6916009)(44832011)(52116002)(66946007)(66476007)(6496006)(66556008)(33656002)(38100700002)(83380400001)(33716001)(4326008)(6666004)(5660300002)(86362001)(8936002)(316002)(9686003)(2906002)(1076003)(186003)(508600001)(55016002)(956004)(26005)(8676002)(9576002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ckz4e803iWSKeRDaESRUmow9OzTbqV8VPwuFdRYJM+Ki4eWfGp4NgonAoeso?= =?us-ascii?Q?OTIZN6zVF/P1LdkMdfvZPRkjHB6QmGwsvu5k/ds6K6cdGkh7BqNffluVyXtG?= =?us-ascii?Q?nmAbOeQFThaS5VChXYAhQbkYKDjK19WnRLOnplbj57F6VRpGNvpXjdnh7BEd?= =?us-ascii?Q?2oVgr4B1+wc1zcXA716SA7FLT4yWLxCnG/S5h6kA/7SmtzOrEshyAzTSucI4?= =?us-ascii?Q?41Sl6tgOf9oBDapAqnkDYBTfOUp2oyd8vgUY/leQZ/ay8+URRZE+sDZiO1EG?= =?us-ascii?Q?fPX1NfX5RZCrqMEPQJN9KhILPQyHEgrCfX2MUiKR4Fa/BySgWmscuKHEF/yb?= =?us-ascii?Q?hrUNY8fkCVG5EijqXJMuDEzDjhTAZlj91A0yN5vHlfr7wHkxRnhrM3izrmAu?= =?us-ascii?Q?b4vH16tcjilM/LV1IJySALWINIVABOuhDsO6i8mMuaSMctlT7JLkw0l0UdOV?= =?us-ascii?Q?d12QV82R/3PwEXRSqFG4HeNMOSY1fIcCRc5Yad+Y/GKe3DFXiSolquiXq+00?= =?us-ascii?Q?Il9w2wekpGVURTGNM6btNqoPFju3SpGRDv/fsAzUTZUNNXDS5bWd053gYOJy?= =?us-ascii?Q?L4dhfDkxCA9nh9Q7Jle2b0VAfKsAvY1DKYdjvPbgYuiy/i0vFz8Z9SA9ZLJl?= =?us-ascii?Q?i/0Ipk9Qp/lzBhyUoRFc92zZDvFAJFmJN0aoDD6DDIQrsMBDVPbo6zZ9/8TF?= =?us-ascii?Q?YbiCxcmERKXMl3S/NXUjO+8Nq7UEJ4JWnigezDJUc9s+zCLW/YlwasDbMYD2?= =?us-ascii?Q?cZOp5Zl8MMijw01hg1vLiHJwhzWg1ycNWw24MqMEQX3nMbo5gYh1cXHsdebg?= =?us-ascii?Q?CKiMm3OeNwSGB2kMac8n2KVf1IPygk2FDGVu2WQegwxtRFHdrWO+fTWXrsjC?= =?us-ascii?Q?pBClkplxQtsGsSkVRHeCDj/iKlybTd96M6QhlG6lRfJqL/0NYJUvx6qF+W56?= =?us-ascii?Q?2Ghko44iNdyNxId7G/FJkoPOf0rU9rhfoNCOnZDOp5t2L92DXmOKA3FGRZ2o?= =?us-ascii?Q?xJPJ3YT7pA6E4K/u7WChe3jvPyRkCFEIMnXaCEXCRai4f8Y0Z0nq6lqjZwyJ?= =?us-ascii?Q?iA0MMvhtpHaQQBSA/koAYRpDmAYTNrX6gaSHprNCgGanwAnDa9qmlog1d7UM?= =?us-ascii?Q?1zb3pG29M08Fg37gjBS3FqEE/8xNjkm5RUKPEujR/mv/JG6JRMo/3455kcfW?= =?us-ascii?Q?0RxEauZSOfttpopf0ggalvf5KHHbQKFTvP+WoMwf6/RYOoJU1Flq/ZLYlKLQ?= =?us-ascii?Q?VSYt7wAkvN0lyALsYkemQZ228zFeS+t28Grrf2zIeIodoN0rXQ/+snibdrcp?= =?us-ascii?Q?ZPbHJk+cbftNg3Rh8Ghr+yg8?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c3e8f37-f646-459d-c061-08d984de864d X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Oct 2021 13:22:32.2033 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Wo9wTJYIQg+P1Y+rB+zcYR/ufLqgSbkr+5vzbTYeA+QbTGNn+E6MGzDIqnFAgHPLfS12CHJPhipsIUfBhdeapPCelT58Cp19MLLbF3OT74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1424 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10123 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=987 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110010089 X-Proofpoint-GUID: d_T0s1IPDYDYrX14V6qdOSpkIWa8ma0w X-Proofpoint-ORIG-GUID: d_T0s1IPDYDYrX14V6qdOSpkIWa8ma0w X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 866F6300398C X-Stat-Signature: ydohiqh9yms5c7ormyzgqnzqsdp1bage Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=u9XaGHzQ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=bdBYtVHE; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf03.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com X-HE-Tag: 1633094581-83910 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Zhenguo Yao, The patch 67b2b441dc10: "hugetlbfs: extend the definition of hugepages parameter to support node allocation" from Sep 29, 2021, leads to the following Smatch static checker warning: mm/hugetlb.c:2957 __alloc_bootmem_huge_page() warn: ignoring unreachable code. mm/hugetlb.c 2940 int __alloc_bootmem_huge_page(struct hstate *h, int nid) 2941 { 2942 struct huge_bootmem_page *m; 2943 int nr_nodes, node; 2944 2945 if (nid >= nr_online_nodes) 2946 return 0; 2947 /* do node specific alloc */ 2948 if (nid != NUMA_NO_NODE) { 2949 m = memblock_alloc_try_nid_raw(huge_page_size(h), huge_page_size(h), 2950 0, MEMBLOCK_ALLOC_ACCESSIBLE, nid); 2951 if (m) 2952 goto found; 2953 else 2954 return 0; 2955 } 2956 /* do all node balanced alloc */ ^^^^^^^^ This says that it's going to loop over "all nodes". --> 2957 for_each_node_mask_to_alloc(h, nr_nodes, node, &node_states[N_MEMORY]) { 2958 m = memblock_alloc_try_nid_raw( 2959 huge_page_size(h), huge_page_size(h), 2960 0, MEMBLOCK_ALLOC_ACCESSIBLE, node); 2961 /* 2962 * Use the beginning of the huge page to store the 2963 * huge_bootmem_page struct (until gather_bootmem 2964 * puts them into the mem_map). 2965 */ 2966 if (m) 2967 goto found; 2968 else 2969 return 0; But it only checks the first node and then returns. 2970 } 2971 2972 found: 2973 /* Put them into a private list first because mem_map is not up yet */ 2974 INIT_LIST_HEAD(&m->list); 2975 list_add(&m->list, &huge_boot_pages); 2976 m->hstate = h; 2977 return 1; 2978 } regards, dan carpenter