From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE72C433F5 for ; Wed, 29 Sep 2021 23:36:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E044B615E6 for ; Wed, 29 Sep 2021 23:36:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E044B615E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 83D1F94006F; Wed, 29 Sep 2021 19:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C56C94003A; Wed, 29 Sep 2021 19:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6668994006F; Wed, 29 Sep 2021 19:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 4EC5394003A for ; Wed, 29 Sep 2021 19:36:27 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1619D2D24C for ; Wed, 29 Sep 2021 23:36:27 +0000 (UTC) X-FDA: 78642222414.40.D82AF35 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf10.hostedemail.com (Postfix) with ESMTP id C6B5660019AE for ; Wed, 29 Sep 2021 23:36:26 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id d8so4013528qtd.5 for ; Wed, 29 Sep 2021 16:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p44CKw5NqI0dRYxuOA5K9AcDSEZdsWaIBA8jXRcCw5I=; b=BPbV7Ye4Bg5a1ZTPc0nR9KOXAhWl4vBzAsDP0t40qxFSH4OCK6/MQKoFgPTEuzSC9v 9WzoiGlY1hhlhin2gZEWJVK42YbLrmi7f51aphr87IllDIDa/mW2TlwOq98Zvj0JRk6r inxpNiGI/a0tzZNBGtrfuGtkApxUXeOUvY5k07EjRTxe3FM8zYJRfjjEr2wiowyupIsP pguKaqLo4Vxp8H1+LxCZCv8O7UiZItzZkw/1xqVdmL+zc9QUl9vc75MtsgPZmJ4AEECN dBdxRWVA8aWYCV8FKdHpO9CE7a3VgpFt7E/hUggJ2cfyrdgPqy3taLCfKIMAeO9CnW6s e4ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p44CKw5NqI0dRYxuOA5K9AcDSEZdsWaIBA8jXRcCw5I=; b=J620ZXknmCrFDiJ5+hg4OWQ4LM2sL+8VfTMBbTMJVCRBwm+dBzypJv/eYM4KoqMluw kjxrmM4EzIqq61x+Cs+IVnS+tGgALPYqsE27+zL1cHK64ktp4Z9ae9/xS+WEGxZhmVhW jQ5sW4eUyV5ox9ttfnaOlzT0e+z9LmAzyvCsYXVZ2ACxqq4FMTrMw+mwG1vOwO1FyE0U qDDpDe5yRKDy8dD/qWagKenJeGCwoDhT9CqLQaKqmjN0rH0UsOvA6PEjcH9DafVoGJXe moljXMsNp1dTE6VXKV1wlbGY60VllN8a0t794n3L9zy6PpF7cnyMdfZ0OiwHP0sa1apj +bRg== X-Gm-Message-State: AOAM531ESPCinZlqquBTk3DuWFEqbATOFaY0ankvttT8OolT7BzuSaSX iNW2Jrb1Fmn+3r7CBCbxaypDKA== X-Google-Smtp-Source: ABdhPJyCMb0x8UTP251JMzz7qx/fZLPDIyTJit8sJRFPeoPnTFgHskOtgm8FIWQl2/TGWg7M25xovg== X-Received: by 2002:a05:622a:492:: with SMTP id p18mr3159519qtx.282.1632958586146; Wed, 29 Sep 2021 16:36:26 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id f5sm706662qtp.44.2021.09.29.16.36.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Sep 2021 16:36:25 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mVj7g-007iwP-Pe; Wed, 29 Sep 2021 20:36:24 -0300 Date: Wed, 29 Sep 2021 20:36:24 -0300 From: Jason Gunthorpe To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni Subject: Re: [PATCH v3 00/20] Userspace P2PDMA with O_DIRECT NVMe devices Message-ID: <20210929233624.GG3544071@ziepe.ca> References: <20210916234100.122368-1-logang@deltatee.com> <20210928200216.GW3544071@ziepe.ca> <06d75fcb-ce8b-30a5-db36-b6c108460d3d@deltatee.com> <20210929232147.GD3544071@ziepe.ca> <93f56919-03ee-8326-10ee-8fbd9078b8e0@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <93f56919-03ee-8326-10ee-8fbd9078b8e0@deltatee.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C6B5660019AE X-Stat-Signature: 5bxkbgfr5twmbr96ga1dhqktnf77bybs Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=BPbV7Ye4; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.171 as permitted sender) smtp.mailfrom=jgg@ziepe.ca X-HE-Tag: 1632958586-754189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 05:28:38PM -0600, Logan Gunthorpe wrote: > > > On 2021-09-29 5:21 p.m., Jason Gunthorpe wrote: > > On Wed, Sep 29, 2021 at 03:50:02PM -0600, Logan Gunthorpe wrote: > >> > >> > >> On 2021-09-28 2:02 p.m., Jason Gunthorpe wrote: > >>> On Thu, Sep 16, 2021 at 05:40:40PM -0600, Logan Gunthorpe wrote: > >>>> Hi, > >>>> > >>>> This patchset continues my work to add userspace P2PDMA access using > >>>> O_DIRECT NVMe devices. My last posting[1] just included the first 13 > >>>> patches in this series, but the early P2PDMA cleanup and map_sg error > >>>> changes from that series have been merged into v5.15-rc1. To address > >>>> concerns that that series did not add any new functionality, I've added > >>>> back the userspcae functionality from the original RFC[2] (but improved > >>>> based on the original feedback). > >>> > >>> I really think this is the best series yet, it really looks nice > >>> overall. I know the sg flag was a bit of a debate at the start, but it > >>> serves an undeniable purpose and the resulting standard DMA APIs 'just > >>> working' is really clean. > >> > >> Actually, so far, nobody has said anything negative about using the SG flag. > >> > >>> There is more possible here, we could also pass the new GUP flag in the > >>> ib_umem code.. > >> > >> Yes, that would be very useful. > > > > You might actually prefer to do that then the bio changes to get the > > infrastructur merged as it seems less "core" > > I'm a little bit more concerned about my patch set growing too large. > It's already at 20 patches and I think I'll need to add a couple more > based on the feedback you've already provided. So I'm leaning toward > pushing more functionality as future work. I mean you could postpone the three block related patches and use a single ib_umem patch instead as the consumer. Jason