From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE08C433EF for ; Mon, 27 Sep 2021 12:19:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AC73061058 for ; Mon, 27 Sep 2021 12:19:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC73061058 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 45B7C6B0071; Mon, 27 Sep 2021 08:19:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40B71900002; Mon, 27 Sep 2021 08:19:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F9AB6B0073; Mon, 27 Sep 2021 08:19:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 1CD766B0071 for ; Mon, 27 Sep 2021 08:19:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BD18E3207A for ; Mon, 27 Sep 2021 12:19:04 +0000 (UTC) X-FDA: 78633257808.14.4C2F1FF Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf04.hostedemail.com (Postfix) with ESMTP id 7FCB050000A6 for ; Mon, 27 Sep 2021 12:19:04 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id i4so76589719lfv.4 for ; Mon, 27 Sep 2021 05:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hzKn1PihSVTLBn07NxNCyepUdSFNC9+ZCpNDni2IA0Q=; b=KWWCYxQH7dXXcsSw6KvI24GDz1Mz+bv/Qopn6VTk6MiAZweawv3GE9zHYH9ARkhe22 ri8eZzYAQeIv9cwXD+9kv7aVIn70pQV8qt9GAzY0P+jhd039IMUJSlUB8m/Aaq47i2Ij akrLz7+j+8CV5ndOeiGlys/XB2nceb7PPDxWi9FVhTewTyhJnkXeBsONOrZEXBPDw+Qm tGNJ46JZZNpL9kgtaQ13hlHNfuCJQ8e5M/U3SwJKZgI0OdMD4im4VEZmZtQ9nQICv1H7 UOb0NQSn1mKE+5yqhLWtJVAml+1r3h9aI9bRLez8J1aZpGNk7a9LTbdnMcoeZHGVYwQG 4WZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hzKn1PihSVTLBn07NxNCyepUdSFNC9+ZCpNDni2IA0Q=; b=2fl2ae4Acf2Fs+z7phzH8Rfg7r2QPBgn1OcYGLaZ5pHRGayjg7OEhFkE5LP+MnCE74 sfoz7h5Tr2U6/ubMgOInEN9260AERS+panWz/SK+T6fqyI7+LFWQqhheGqJCZLYuYdiz +fs77ed5G3giM/iPKqHl+ogiLj4Nr4+qGH3CWt828eg+uO7+fRPYlYpF+fSj7+8XUKHZ lLtcNW2yr0+mfNBrE69cw941mW2N1/lh0yOfEpfFvgcxsYYnGaULElnLCdwDP/41nKO0 D4PJ48P6lWFBFjJNHmJHsvY/0HyruQb50pxOKY3g9od9EUpn79dwbluo/zM87iJNxJGQ QW1Q== X-Gm-Message-State: AOAM530+hdvqbe8eIIlggDMO2RL7Gjl24mJstXnut3Eni2Bi4PO8OHwC 1TPqeAGiDrWEFUJIYlAVFZqtlw== X-Google-Smtp-Source: ABdhPJxb7Hx7XDrSV8+tSwjeT7uO8LkszuIvMqEi+lFexR7KTie06Phg7EB/AEUXzYIGhxWZxNB5OQ== X-Received: by 2002:ac2:54a6:: with SMTP id w6mr23291702lfk.61.1632745143223; Mon, 27 Sep 2021 05:19:03 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id d12sm1476888lfs.283.2021.09.27.05.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 05:19:02 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 55AD3102FD9; Mon, 27 Sep 2021 15:19:02 +0300 (+03) Date: Mon, 27 Sep 2021 15:19:02 +0300 From: "Kirill A. Shutemov" To: Nadav Amit Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Xu , Andrea Arcangeli , Minchan Kim , Colin Cross , Suren Baghdasarya , Mike Rapoport Subject: Re: [RFC PATCH 2/8] mm/madvise: remove unnecessary check on madvise_dontneed_free() Message-ID: <20210927121902.r5gslag4nvvseoxo@box> References: <20210926161259.238054-1-namit@vmware.com> <20210926161259.238054-3-namit@vmware.com> <20210927091143.tn6ediykqycu6rtu@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=KWWCYxQH; spf=none (imf04.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.49) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7FCB050000A6 X-Stat-Signature: an7m59c3mjip3q7ktw95zf681ph8moph X-HE-Tag: 1632745144-202098 X-Bogosity: Ham, tests=bogofilter, spamicity=0.223188, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 27, 2021 at 04:05:47AM -0700, Nadav Amit wrote: > Having said that, if you want, I can turn this condition into > WARN_ON_ONCE() or VM_BUG_ON(), although I really see no reason to > do so. BUILD_BUG() should be fine here. -- Kirill A. Shutemov