From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FADC433FE for ; Mon, 27 Sep 2021 09:31:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3642861165 for ; Mon, 27 Sep 2021 09:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3642861165 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D563394000B; Mon, 27 Sep 2021 05:31:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D04EC6B0075; Mon, 27 Sep 2021 05:31:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF45294000B; Mon, 27 Sep 2021 05:31:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id B05BD6B0074 for ; Mon, 27 Sep 2021 05:31:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 708B51802F64F for ; Mon, 27 Sep 2021 09:31:06 +0000 (UTC) X-FDA: 78632834532.01.713246A Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf06.hostedemail.com (Postfix) with ESMTP id 34E3F801A89C for ; Mon, 27 Sep 2021 09:31:06 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id z24so75339629lfu.13 for ; Mon, 27 Sep 2021 02:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tGZj9UfzMOvrlmJlZWhVCYko1Gj7jAZ5QKpn2O8GHnQ=; b=fH7ElhPz/j0dkKN0IQlRwL6IKNF50qPdlSMdP3FrEeL1cT4duKYSrOaeKFQE5tK8MH NKI948ew/JhYYQ+jjF5z0G1HI1dHwAWv2H4R4LPPB9e0kyWGUgdsuD0ZPeeKEnzbihqn kd+XgcA0my6muCpI2/S1tm/wco+vpwCQvlNfb26uFYxFICWUZQaWLHxD//8pnErb+XHa wX4XqByN7PkBbMUXlZidhCn5rssyvGK3qzWxHqaHJ5Hh10vwDQzFtD01sJCxUdUotmsR ptOLfSNmuocRCfcbmwyvq3+nlmZ3ASxRX8qAkaNw2ZxHQUQIRevcyWlZYqXHR9ZTKBJH xnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tGZj9UfzMOvrlmJlZWhVCYko1Gj7jAZ5QKpn2O8GHnQ=; b=IDW5Vs0dokYaPtbsWjqA+0euXaInZfc3cvtJbsGBmR6CPY44+yTieykW7EIyl8H3xM jmGC+8JOzWPNsmNld8awYeIOPOulaUqHSmnwbXla/Kiisdl4aYb+pXhrukkJuZxNLj4v 5EnYOugCx8kzZOBLaw51p9x5ibw1WAwn2QcRlGivhhj01NfFC3Rn2OVdHvnwRKHTEWNc +H0odzVS99WC5OUR4Aw0Y8FEAWMr4N6+0MUTZTtxG1Hn8XzONsbK8qi5L6eVlerHCWWd sIx6yfoDz1m2SUSsevXsefkHVAKfYrfeEDUrZnVvLlylv9UxqoyWKre65ArHwz/oCG8h cDcg== X-Gm-Message-State: AOAM531VO9HPoCHco9any/4NWjD23yVhUWA7ulT53rPVlCJMGUftEKi/ uUUHuRPHRTxOnh8tW0oizJouFQ== X-Google-Smtp-Source: ABdhPJyZTPI/P8FivbJz92AxtI5RRIDNYzf9SMmh9JOwXEWai1lvhn8xX3PqLTWDDMSVbdhS3dZcNA== X-Received: by 2002:a05:651c:21b:: with SMTP id y27mr27606230ljn.489.1632735064625; Mon, 27 Sep 2021 02:31:04 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id u27sm1540438lfm.38.2021.09.27.02.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 02:31:04 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 625B510306C; Mon, 27 Sep 2021 12:31:03 +0300 (+03) Date: Mon, 27 Sep 2021 12:31:03 +0300 From: "Kirill A. Shutemov" To: Nadav Amit Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Xu , Nadav Amit , Andrea Arcangeli , Minchan Kim , Colin Cross , Suren Baghdasarya , Mike Rapoport Subject: Re: [RFC PATCH 4/8] mm/madvise: define madvise behavior in a struct Message-ID: <20210927093103.g3cszw75gfctwtzk@box.shutemov.name> References: <20210926161259.238054-1-namit@vmware.com> <20210926161259.238054-5-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210926161259.238054-5-namit@vmware.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 34E3F801A89C X-Stat-Signature: oq986sm16w58b5e6dg78rtn1henaz3p1 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=fH7ElhPz; dmarc=none; spf=none (imf06.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.47) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1632735066-874108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 26, 2021 at 09:12:55AM -0700, Nadav Amit wrote: > From: Nadav Amit > > The different behaviors of madvise are different in several ways, which > are distributed across several functions. Use the design pattern from > iouring in order to define the actions that are required for each > behavior. > > The next patches will get rid of old helper functions that are modified > in this patch and the redundant use of array_index_nospec(). The next > patches will add more actions for each leaf into the new struct. > > No functional change is intended. > > Cc: Andrea Arcangeli > Cc: Andrew Morton > Cc: Minchan Kim > Cc: Colin Cross > Cc: Suren Baghdasarya > Cc: Mike Rapoport > Signed-off-by: Nadav Amit > --- > mm/madvise.c | 168 +++++++++++++++++++++++++++++++++------------------ > 1 file changed, 109 insertions(+), 59 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 17e39c70704b..127507c71ba9 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > > #include > > @@ -39,6 +40,101 @@ struct madvise_walk_private { > bool pageout; > }; > > +struct madvise_info { > + u8 behavior_valid: 1; > + u8 process_behavior_valid: 1; > + u8 need_mmap_read_only: 1; > +}; > + > +static const struct madvise_info madvise_info[MADV_SOFT_OFFLINE+1] = { MADV_SOFT_OFFLINE+1 smells bad. And I don't like the change in general. Given that MADV_SOFT_OFFLINE is 101, the array will be mostly empty. I donno. I don't see any improvement with the patch. But maybe it's only me. -- Kirill A. Shutemov