From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B2CC433F5 for ; Mon, 27 Sep 2021 09:24:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 490D361157 for ; Mon, 27 Sep 2021 09:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 490D361157 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DF7FC940008; Mon, 27 Sep 2021 05:24:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA89E6B0073; Mon, 27 Sep 2021 05:24:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C71A4940008; Mon, 27 Sep 2021 05:24:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id B8BF56B0072 for ; Mon, 27 Sep 2021 05:24:35 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 75AB9181AC9B6 for ; Mon, 27 Sep 2021 09:24:35 +0000 (UTC) X-FDA: 78632818110.21.89D47E3 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf04.hostedemail.com (Postfix) with ESMTP id 2F7CC50000A8 for ; Mon, 27 Sep 2021 09:24:35 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id m3so74693408lfu.2 for ; Mon, 27 Sep 2021 02:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Tyy6Dv7V4fb/Ljhb18nEvTV2h/rNzPynwFMmcx94u8M=; b=Px18PFMmqv5tM0ES8a9DDmI150bGqOY2axThJnD9LQD345HFLscARXZ7aNBhhL6O9w OlBxtwbGSgDcaO1tiDwu4HCuvbedUfA5kRiqW9fCvubYCDFeF7rsQkeirLA6AB9lDB/+ 98D4prIrxs2zuHq+abJdHTtImN4MZ6SZcve32xEzHpT4+OdJq2l8OEAMiq83Zk87UMod klxZJpckzW1ev6CxHOj8DP4bmrRwNgWH8pm6RSylRwDUFPZ0tzQivrWecSDw+ffgv0fi DtnfuBWoG7JjfUuOBGdlE7kj2kcCELWQWqUxwX2lNaamIIYTGBkdCuSGw43dWJoeY49U rLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Tyy6Dv7V4fb/Ljhb18nEvTV2h/rNzPynwFMmcx94u8M=; b=4JJEGwxtuqme3hZpRCCrO2N9/2q1MG/9m7LidyhyQhO8h+mrIoteQ6MgLeRG7naOlK dcWIUZgSsqZhDwQhjNYhqVvmqOglyHTKLoCqEcwTf+E9eRRE9FyxZTBZec4UFwpOD3tl CHzRmoTZTO1g1G5ELQYvA3s7gOV13kimqb5xQz/WGNzd3Q8nnVkDg+U9xqQ6y2/x1ghL ouF6zxsUYRCtDRvpVrlv+X6VtmijnAGC9aB4us4b7dk051ypuMsfi0RCFb/UeEjcG0Jq fY/B+iqKyT79PpCe1SKCBRQ1g7WMVgSSXTDm5ei40YyjP/Lw8o23Mer0aggBpbg+2LhC ezFA== X-Gm-Message-State: AOAM533j3eEeAzW/Ntnb50VwRZ8YvoRCNiFESgMENcObpjuPopjeTs2h 3Xc0D3Yw1Vf8vpLSCH22pOlmeQ== X-Google-Smtp-Source: ABdhPJwlx60z2P3MK7KYZvU/sSyo2JgYRYCh8HGrQBPKJikovN0Mp+E6gRY9yo5sLsfCMA1mpREAFA== X-Received: by 2002:a05:6512:3ee:: with SMTP id n14mr24062637lfq.589.1632734673773; Mon, 27 Sep 2021 02:24:33 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id u14sm1538020lfi.231.2021.09.27.02.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 02:24:33 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id B29CC10306C; Mon, 27 Sep 2021 12:24:32 +0300 (+03) Date: Mon, 27 Sep 2021 12:24:32 +0300 From: "Kirill A. Shutemov" To: Nadav Amit Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Xu , Nadav Amit , Andrea Arcangeli , Minchan Kim , Colin Cross , Suren Baghdasarya , Mike Rapoport Subject: Re: [RFC PATCH 3/8] mm/madvise: remove unnecessary checks on madvise_free_single_vma() Message-ID: <20210927092432.qdshyj67lkiq2cbv@box.shutemov.name> References: <20210926161259.238054-1-namit@vmware.com> <20210926161259.238054-4-namit@vmware.com> <20210927091709.ksv2fjudjpqhnu3n@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210927091709.ksv2fjudjpqhnu3n@box.shutemov.name> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2F7CC50000A8 X-Stat-Signature: o6wsq8ep7zdx4jb78bjuqebm5e3rgg9f Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=Px18PFMm; dmarc=none; spf=none (imf04.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.44) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1632734675-455021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 27, 2021 at 12:17:09PM +0300, Kirill A. Shutemov wrote: > On Sun, Sep 26, 2021 at 09:12:54AM -0700, Nadav Amit wrote: > > From: Nadav Amit > > > > madvise_free_single_vma() currently rechecks that the range fits within > > the VMA, adapts it accordingly, and returns -EINVAL if the range is > > entirely outside of the VMA. > > > > The error-code of -EINVAL is incorrect according to the man pages (as it > > should have been -ENOMEM), but anyhow the range that is provided to > > madvise_free_single_vma() should always be valid. It is set correctly in > > do_madvise() and then rechecked in madvise_dontneed_free() is the s/is/if/ > > mmap-lock is dropped. > > > > Remove this check. > > > > Cc: Andrea Arcangeli > > Cc: Andrew Morton > > Cc: Minchan Kim > > Cc: Colin Cross > > Cc: Suren Baghdasarya > > Cc: Mike Rapoport > > Signed-off-by: Nadav Amit > > --- > > mm/madvise.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index fe843513a4e8..17e39c70704b 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -716,14 +716,8 @@ static int madvise_free_single_vma(struct vm_area_struct *vma, > > if (!vma_is_anonymous(vma)) > > return -EINVAL; > > > > - range.start = max(vma->vm_start, start_addr); > > - if (range.start >= vma->vm_end) > > - return -EINVAL; > > - range.end = min(vma->vm_end, end_addr); > > - if (range.end <= vma->vm_start) > > - return -EINVAL; > > How did you test this change? > > As far as I can see, you leave 'range' uninitialized, but used for > walk_page_range() and mmu_notifiers. > > NAK. Sorry. My bad. mmu_notifier_range_init will init the range even if mmu notifiers are disabled. > > > mmu_notifier_range_init(&range, MMU_NOTIFY_CLEAR, 0, vma, mm, > > - range.start, range.end); > > + start_addr, end_addr); > > > > lru_add_drain(); > > tlb_gather_mmu(&tlb, mm); > > -- > > 2.25.1 > > > > > > -- > Kirill A. Shutemov -- Kirill A. Shutemov