From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A6AC433F5 for ; Mon, 27 Sep 2021 09:11:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D42C60184 for ; Mon, 27 Sep 2021 09:11:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D42C60184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B9536900002; Mon, 27 Sep 2021 05:11:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B457D6B0072; Mon, 27 Sep 2021 05:11:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3444900002; Mon, 27 Sep 2021 05:11:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 97B506B0071 for ; Mon, 27 Sep 2021 05:11:46 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 49B2A31EB2 for ; Mon, 27 Sep 2021 09:11:46 +0000 (UTC) X-FDA: 78632785812.31.9EEFD26 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf08.hostedemail.com (Postfix) with ESMTP id EFC6630000A0 for ; Mon, 27 Sep 2021 09:11:45 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id i4so74320095lfv.4 for ; Mon, 27 Sep 2021 02:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WjdgfNID1F56pN/ToVuugx7UPq8+diudyxoBfhqPDek=; b=CZ0INnd+an0mI0YdfzuS/n5CtlqpiQBbC3XKcsLZ6DET1fsm18OachI2raiJmeEDZn mo2U8zBEjNExo9Bfm/u8YK2XOajIDPBbTzwblyvny/q2O/Ns4eFcU9ctYWg+BvZTxXxQ 4BQQDihSMkbr6f+DY31NKdXMMac3XLQQ7O5oOxyFbKHjfCqU+5aLHJDQMIaQ4nVsgjyQ awRjzp57HaD0/hZ56iHukLLMdysVUvUCrlPVxQQBSt+7eh2HKG/ejW5LWfT2WrGpDaWH QNMxbKmPrDZzF4s9CE4h9PvmjtaVeQ1hx5Fo7zHQPqv3hIaXv6INnP/EoHbwBBU7jwc0 EYNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WjdgfNID1F56pN/ToVuugx7UPq8+diudyxoBfhqPDek=; b=UMUN/Kd6QrV7Y9cD96s1zrT7yz2SUZ4dHQFITE+lMrlwcRhF0AsuOkgKitTDtb7tMt N3XtCAeur///voEMQw/Bf5XsP6If8MSl/LIqqm1VjgwlSj2267Wo7QY55mdazHOlpFT6 dA/xVmQ85drEWywxNBXvuAM4F8gsB3xrnWbB7YlO0gg3ZrpUIK20oZi1JCLErqt1EnKH Y20AyF4oUgZ/VYQ5zrO6paWNutY+GbMdsaoO3M7e3aOtlIm+2NvljoRWYRLqP0sTB2Ey hoJQvqEgIDhvaRcZrhkIHrrtViiHRtzZ/YREQHtw5lXEenqqURxJ7DZHv1U3BhI/VK5T ZZTQ== X-Gm-Message-State: AOAM532UfALnUyfKt5VLj/aBSDaxK6IIu5SRHu7W/B2BY6oFxvu3La5J oLbB02IwM6uiq1dtjJMVfa2cBQ== X-Google-Smtp-Source: ABdhPJxOl9/7WzKIWOyEWXlwozmClPTfR7YGpoRlSDC00W0KLvRODwhCKeBhnaXXhi6/XbkebyxQZA== X-Received: by 2002:a05:6512:b81:: with SMTP id b1mr23370847lfv.301.1632733904548; Mon, 27 Sep 2021 02:11:44 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id d16sm1526937lfg.138.2021.09.27.02.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 02:11:43 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4D17910306C; Mon, 27 Sep 2021 12:11:43 +0300 (+03) Date: Mon, 27 Sep 2021 12:11:43 +0300 From: "Kirill A. Shutemov" To: Nadav Amit Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Xu , Nadav Amit , Andrea Arcangeli , Minchan Kim , Colin Cross , Suren Baghdasarya , Mike Rapoport Subject: Re: [RFC PATCH 2/8] mm/madvise: remove unnecessary check on madvise_dontneed_free() Message-ID: <20210927091143.tn6ediykqycu6rtu@box.shutemov.name> References: <20210926161259.238054-1-namit@vmware.com> <20210926161259.238054-3-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210926161259.238054-3-namit@vmware.com> X-Rspamd-Queue-Id: EFC6630000A0 X-Stat-Signature: 6syzqnctss36t4j83rgrmia1ydu41n35 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=CZ0INnd+; spf=none (imf08.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.47) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam06 X-HE-Tag: 1632733905-133030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.042305, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 26, 2021 at 09:12:53AM -0700, Nadav Amit wrote: > From: Nadav Amit > > madvise_dontneed_free() is called only from madvise_vma() and the > behavior is always either MADV_FREE or MADV_DONTNEED. There is no need > to check again in madvise_dontneed_free() if the behavior is any > different. So what. The check is free. Compiler should be clever enough to eliminate the additional check. If there's a new MADV_DONTNEED flavour, the change would have to be effectively reverted. NAK. -- Kirill A. Shutemov