From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FED8C433F5 for ; Sun, 26 Sep 2021 05:45:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FBCF6108E for ; Sun, 26 Sep 2021 05:45:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0FBCF6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 23A016B0071; Sun, 26 Sep 2021 01:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E9836B0072; Sun, 26 Sep 2021 01:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9586B0073; Sun, 26 Sep 2021 01:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id F2EA66B0071 for ; Sun, 26 Sep 2021 01:45:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 93FC72D241 for ; Sun, 26 Sep 2021 05:45:55 +0000 (UTC) X-FDA: 78628638270.06.1D3A2C2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id 4874A7001A24 for ; Sun, 26 Sep 2021 05:45:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8848361038; Sun, 26 Sep 2021 05:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632635142; bh=hFg5IwklbfMfqsMt3D1a9kK21QQ20aDYL7Nh2srwfkg=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=lY1It5jlU+2Cm2iaURXs5QIt1x3ioZ6wiS5VskQXaNMTUz/siaiI2nmvJk6WFeUn7 VcNDRZKRHbGnLQ59ahIlP5WYLEJI8bTIyILAOEW7R+F7ps6q7KwNjC/TMVvlBHhTq6 ByBPCWzscnFYajnradqBjOuBPzBuTcYdAphusD+V6FBLMysmU8r/6UVHfLMxi/Jtsq /HSUTHUm/10P17SFzZNAUEzTtkfnozLF5z1AUGaUcdInkLCxjvQ855Fy4C5eOO9qUJ 5vtK6/BCj6h5qXBeFTNN6V5q/x6HR6yvfanp6W55GVNJBumFGHhLSY+m42rQXfhXPv +Di5EPq/YSwqg== From: SeongJae Park To: Colin King Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL Date: Sun, 26 Sep 2021 05:45:39 +0000 Message-Id: <20210926054539.11630-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210925215908.181226-1-colin.king@canonical.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4874A7001A24 X-Stat-Signature: 5bwkopuqqjuryftj8uafuy9gsz3m1ywp Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lY1It5jl; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1632635155-183590 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Colin, thank you for the patch! > From: Colin Ian King > > Currently a plain integer is being used to nullify the > pointer ctx->kdamond. Use NULL instead. Cleans up sparse > warning: > > mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer > > Signed-off-by: Colin Ian King Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 874558a790a0..c8665c80577a 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx) > nr_running_ctxs); > if (IS_ERR(ctx->kdamond)) { > err = PTR_ERR(ctx->kdamond); > - ctx->kdamond = 0; > + ctx->kdamond = NULL; > } > } > mutex_unlock(&ctx->kdamond_lock); > -- > 2.32.0