linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Chris Goldsworthy <quic_cgoldswo@quicinc.com>
To: David Hildenbrand <david@redhat.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	Chris Goldsworthy <quic_cgoldswo@quicinc.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	"Will Deacon" <will@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Sudarshan Rajagopalan <quic_sudaraja@quicinc.com>,
	"Doug Berger" <opendmb@gmail.com>
Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug
Date: Fri, 24 Sep 2021 13:52:58 -0700	[thread overview]
Message-ID: <20210924205258.GA17966@hu-cgoldswo-sd.qualcomm.com> (raw)
In-Reply-To: <41789cad-76c6-0ea5-4aa1-3e4a52acff86@redhat.com>


Thanks for the response David.

On Fri, Sep 24, 2021 at 10:17:46AM +0200, David Hildenbrand wrote:
> no-map means that no direct mapping is to be created, right? We would still
> have a memmap IIRC, and the pages are PG_reserved.
> 
> Again, I think this is very similar to just having no-map regions like
> random memory holes within the existing memory layout.

For those curious, see __reserved_mem_alloc_size() >
early_init_dt_alloc_reserved_memory_arch() > memblock_mark_nomap() - the
'no-map' attribute is read in __reserved_mem_alloc_size() and the pre-requisite
steps need to have the relevant struct pages marked as PG_reserved 
are taken in memblock_mark_nomap().

> What Chris proposes here is very similar to
> arch/x86/mm/init_64.c:update_end_of_memory_vars() called during
> arch_add_memory()->add_pages() on x86-64.
> 

For other's reference, the patch was derived from what x86 is doing with max_pfn
(such that we also set max_low_pfn as is done in arm64's mm/init.c.


  reply	other threads:[~2021-09-24 20:53 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 22:54 Chris Goldsworthy
2021-09-23 22:54 ` Chris Goldsworthy
2021-09-24  2:47   ` Florian Fainelli
2021-09-24  8:17     ` David Hildenbrand
2021-09-24 20:52       ` Chris Goldsworthy [this message]
2021-09-25  0:36       ` Sudarshan Rajagopalan
2021-09-27 15:51   ` David Hildenbrand
2021-09-27 23:22     ` Georgi Djakov
2021-09-28  6:12       ` Chris Goldsworthy
2021-09-28  7:33         ` David Hildenbrand
2021-09-27 17:22   ` Georgi Djakov
2021-09-27 17:34     ` David Hildenbrand
2021-09-27 20:00       ` Georgi Djakov
2021-09-27 20:14         ` David Hildenbrand
2021-09-27 23:01           ` Georgi Djakov
2021-09-29 10:10   ` Will Deacon
2021-09-29 10:29     ` David Hildenbrand
2021-09-29 10:42       ` Will Deacon
2021-09-29 10:49         ` David Hildenbrand
2021-09-29 11:03           ` Will Deacon
2021-09-29 12:09             ` David Hildenbrand
2021-09-29 12:51               ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924205258.GA17966@hu-cgoldswo-sd.qualcomm.com \
    --to=quic_cgoldswo@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=opendmb@gmail.com \
    --cc=quic_sudaraja@quicinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox