From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9242C433F5 for ; Thu, 23 Sep 2021 14:39:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C90A61268 for ; Thu, 23 Sep 2021 14:39:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C90A61268 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A90B76B006C; Thu, 23 Sep 2021 10:39:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A405C6B0071; Thu, 23 Sep 2021 10:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E133900002; Thu, 23 Sep 2021 10:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 7AEB16B006C for ; Thu, 23 Sep 2021 10:39:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2363D1802EB2C for ; Thu, 23 Sep 2021 14:39:05 +0000 (UTC) X-FDA: 78619095450.12.5420553 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf17.hostedemail.com (Postfix) with ESMTP id D0152F000392 for ; Thu, 23 Sep 2021 14:39:04 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id t10so27636020lfd.8 for ; Thu, 23 Sep 2021 07:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=21b0k6N9522huwD1D3UiPVs+eYwH7HdWgHDdKuhyH2I=; b=wjqslYxLsLqD0NNmIk13VnZkNZ8aZRqvCGd5J3hlaLZLdwY3eg2O188Vq0tnJx9gIU +eq+N8WmWrCjZeMDo8ODLmwAR1qCI/EThgtYhyIEhxt6PGzVURUNCxmT+QtsGbfrLVKc +tXxPBr2A5gEqZa8xotOloONAUzeVXy2mo3sTGlGjqP6wojBheytUc3aD1r5aG9IIHR3 iXI2TVSkMpvGz5EG7uQOoD3SJzpSDmEvZsDKyGMQZoKNQNHznln65M+TE5fDAy2xMsxz HKX4sprwsJ/p8312p6HEJxBkkJK/AGZM+igOGOSJesayVRNJFs0PBzZi2vuOPiHwkK6B yVbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=21b0k6N9522huwD1D3UiPVs+eYwH7HdWgHDdKuhyH2I=; b=lAVTpF51vLpbH4UHkltocvkS4dXeB0tnFWt5FVFaHxkzKWenkU9Mfw2vAYIFtwzIGG kk3L4/jYnUDFd8H15oDESCnT9dflSRZfFtyC8xlpkqzjy+pg8VOI0Hm+JO1DrWrbcHe9 Xkti1cMRNn1hCFHRdRvsJu5L3Kh7ABtkjc7enz6nTM1OkL1ZlxWcnBdwy5PhJdaOktAl TovQiUTBLH2z/Xk4xDjZkf4Q1/7TtJb93DZ1VeLFD0ggormnGtRcOZ5Wk9SAqqPG+e4Z a51drkO693XPBZc8UbHgDUyrGEEeSph6EupS+V31dsOsVFaOn2PmHiFYklgUrFMop5Oh bGoA== X-Gm-Message-State: AOAM532KCQOzfUACoad5a9yt4biW/ki3liowkgZ0/nf/8Jt9YzOSTYgq v1bheBpjubMy32/oUL/fhwm+wQ== X-Google-Smtp-Source: ABdhPJwjmC/zbN0YHpPzPGyin8WcYkmUxmeaEAXkqeGBlVdE7uW7FNzgY5/6thLKNDfaHWv1sTAMCA== X-Received: by 2002:ac2:46c8:: with SMTP id p8mr4476596lfo.158.1632407940111; Thu, 23 Sep 2021 07:39:00 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v5sm476208lfq.154.2021.09.23.07.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 07:38:59 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id B39C110306C; Thu, 23 Sep 2021 17:39:01 +0300 (+03) Date: Thu, 23 Sep 2021 17:39:01 +0300 From: "Kirill A. Shutemov" To: Yang Shi Cc: naoya.horiguchi@nec.com, hughd@google.com, kirill.shutemov@linux.intel.com, willy@infradead.org, peterx@redhat.com, osalvador@suse.de, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 PATCH 1/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault Message-ID: <20210923143901.mdc6rejuh7hmr5vh@box.shutemov.name> References: <20210923032830.314328-1-shy828301@gmail.com> <20210923032830.314328-2-shy828301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210923032830.314328-2-shy828301@gmail.com> X-Stat-Signature: 7ssq4gnwwmtyaht33omf43ryhnmj89ec Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=wjqslYxL; dmarc=none; spf=none (imf17.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.53) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D0152F000392 X-HE-Tag: 1632407944-10297 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000161, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 22, 2021 at 08:28:26PM -0700, Yang Shi wrote: > When handling shmem page fault the THP with corrupted subpage could be PMD > mapped if certain conditions are satisfied. But kernel is supposed to > send SIGBUS when trying to map hwpoisoned page. > > There are two paths which may do PMD map: fault around and regular fault. > > Before commit f9ce0be71d1f ("mm: Cleanup faultaround and finish_fault() codepaths") > the thing was even worse in fault around path. The THP could be PMD mapped as > long as the VMA fits regardless what subpage is accessed and corrupted. After > this commit as long as head page is not corrupted the THP could be PMD mapped. > > In the regulat fault path the THP could be PMD mapped as long as the corrupted s/regulat/regular/ > page is not accessed and the VMA fits. > > This loophole could be fixed by iterating every subpage to check if any > of them is hwpoisoned or not, but it is somewhat costly in page fault path. > > So introduce a new page flag called HasHWPoisoned on the first tail page. It > indicates the THP has hwpoisoned subpage(s). It is set if any subpage of THP > is found hwpoisoned by memory failure and cleared when the THP is freed or > split. > > Cc: > Suggested-by: Kirill A. Shutemov > Signed-off-by: Yang Shi > --- ... > diff --git a/mm/filemap.c b/mm/filemap.c > index dae481293b5d..740b7afe159a 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -3195,12 +3195,14 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > } > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { > - vm_fault_t ret = do_set_pmd(vmf, page); > - if (!ret) { > - /* The page is mapped successfully, reference consumed. */ > - unlock_page(page); > - return true; > - } > + vm_fault_t ret = do_set_pmd(vmf, page); > + if (ret == VM_FAULT_FALLBACK) > + goto out; Hm.. What? I don't get it. Who will establish page table in the pmd then? > + if (!ret) { > + /* The page is mapped successfully, reference consumed. */ > + unlock_page(page); > + return true; > + } > } > > if (pmd_none(*vmf->pmd)) { > @@ -3220,6 +3222,7 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > return true; > } > > +out: > return false; > } > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 5e9ef0fc261e..0574b1613714 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2426,6 +2426,8 @@ static void __split_huge_page(struct page *page, struct list_head *list, > /* lock lru list/PageCompound, ref frozen by page_ref_freeze */ > lruvec = lock_page_lruvec(head); > > + ClearPageHasHWPoisoned(head); > + Do we serialize the new flag with lock_page() or what? I mean what prevents the flag being set again after this point, but before ClearPageCompound()? -- Kirill A. Shutemov