From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65A17C433F5 for ; Tue, 21 Sep 2021 11:16:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 17BC360ED5 for ; Tue, 21 Sep 2021 11:16:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17BC360ED5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A413D94000E; Tue, 21 Sep 2021 07:16:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EEFA940009; Tue, 21 Sep 2021 07:16:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DEB794000E; Tue, 21 Sep 2021 07:16:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 7C492940009 for ; Tue, 21 Sep 2021 07:16:34 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3805C181C98EF for ; Tue, 21 Sep 2021 11:16:34 +0000 (UTC) X-FDA: 78611327508.32.ABF498B Received: from outbound-smtp16.blacknight.com (outbound-smtp16.blacknight.com [46.22.139.233]) by imf20.hostedemail.com (Postfix) with ESMTP id CFCB5D0000B6 for ; Tue, 21 Sep 2021 11:16:33 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp16.blacknight.com (Postfix) with ESMTPS id 7641A1C5FB8 for ; Tue, 21 Sep 2021 12:16:32 +0100 (IST) Received: (qmail 24510 invoked from network); 21 Sep 2021 11:16:32 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Sep 2021 11:16:32 -0000 Date: Tue, 21 Sep 2021 12:16:30 +0100 From: Mel Gorman To: NeilBrown Cc: Linux-MM , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Linux-fsdevel , LKML Subject: Re: [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made Message-ID: <20210921111630.GR3959@techsingularity.net> References: <20210920085436.20939-1-mgorman@techsingularity.net> <20210920085436.20939-4-mgorman@techsingularity.net> <163218069080.3992.14261132300912173043@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <163218069080.3992.14261132300912173043@noble.neil.brown.name> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf20.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.233 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Stat-Signature: czuhtmurau39ism4odd61z8trtaf3ao1 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CFCB5D0000B6 X-HE-Tag: 1632222993-404807 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 09:31:30AM +1000, NeilBrown wrote: > On Mon, 20 Sep 2021, Mel Gorman wrote: > > + > > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_NOPROGRESS, HZ/10); > > We always seem to pass "HZ/10" to reclaim_throttle(). Should we just > hard-code that in the one place inside reclaim_throttle() itself? > do_writepages passes in HZ/50. I'm not sure if these values even have any special meaning, I think it's more likely they were pulled out of the air based on the speed of some disk in the past and then copied. It's another reason why I want the wakeups to be based on events within the mm as much as possible. -- Mel Gorman SUSE Labs