From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFC4C433FE for ; Tue, 21 Sep 2021 06:37:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7FAE60E73 for ; Tue, 21 Sep 2021 06:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D7FAE60E73 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4531E6B0071; Tue, 21 Sep 2021 02:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 404256B0072; Tue, 21 Sep 2021 02:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F2246B0073; Tue, 21 Sep 2021 02:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 20C8F6B0071 for ; Tue, 21 Sep 2021 02:37:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B56DF2C6B2 for ; Tue, 21 Sep 2021 06:37:00 +0000 (UTC) X-FDA: 78610623000.07.F704364 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 414A3D0000A3 for ; Tue, 21 Sep 2021 06:37:00 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2E07567373; Tue, 21 Sep 2021 08:36:57 +0200 (CEST) Date: Tue, 21 Sep 2021 08:36:57 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , axboe@kernel.dk, linux-block@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/17] mm: don't include in Message-ID: <20210921063656.GA23945@lst.de> References: <20210920123328.1399408-1-hch@lst.de> <20210920123328.1399408-2-hch@lst.de> <50b75915-b61f-d3aa-b8ab-bd790adc04af@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50b75915-b61f-d3aa-b8ab-bd790adc04af@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 414A3D0000A3 Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: epetnytmysqsmxchasqrkcdhjgbf83oa X-HE-Tag: 1632206220-39977 X-Bogosity: Ham, tests=bogofilter, spamicity=0.012402, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 20, 2021 at 03:13:15PM -0700, Bart Van Assche wrote: >> +#define wbc_blkcg_css(wbc) \ >> + ((wbc)->wb ? (wbc)->wb->blkcg_css : blkcg_root_css) >> +#else >> +#define wbc_blkcg_css(wbc) (blkcg_root_css) >> +#endif /* CONFIG_CGROUP_WRITEBACK */ > > This change may introduce annoying set-but-not-used warnings > with CONFIG_CGROUP_WRITEBACK=n. How about changing (blkcg_root_css) > into ((wbc), blkcg_root_css) to prevent this? I agree in principle, but in this case the caller pretty much has to use wbc in other ways, so I don't think it matters much.