From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72581C433EF for ; Sun, 19 Sep 2021 22:40:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3B2360C51 for ; Sun, 19 Sep 2021 22:40:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F3B2360C51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F02D2900003; Sun, 19 Sep 2021 18:40:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB190900002; Sun, 19 Sep 2021 18:40:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9FC5900003; Sun, 19 Sep 2021 18:40:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id CC196900002 for ; Sun, 19 Sep 2021 18:40:06 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8D3DF29E19 for ; Sun, 19 Sep 2021 22:40:06 +0000 (UTC) X-FDA: 78605792412.30.7257BB1 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id 50E72D0000AD for ; Sun, 19 Sep 2021 22:40:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E8EA60C51; Sun, 19 Sep 2021 22:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1632091202; bh=GuEk0gNS4MnI/zqtpKABR7rKjnbnL6OqyGpa++pLW4w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gya7g2DehzyQg8knIIoM8bOAse/WVChb3od20NpjLg5Coy9nArtY5oC0/CpE/Ou7D ZAWJYU6/MdUVjM5vhHnEgOX4hJhY7oCxRhw2/mq3dplsZXTWNMgTkEb5a7wZngCNZH xdJ+W9VXP2NMBrBYpP2hBsuEqe+tboFW+UFgKGpQ= Date: Sun, 19 Sep 2021 15:40:00 -0700 From: Andrew Morton To: Sultan Alsawaf Cc: Michal Hocko , David Rientjes , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Mark the OOM reaper thread as freezable Message-Id: <20210919154000.2dbd44c146c18e65d5dbce37@linux-foundation.org> In-Reply-To: <20210918233920.9174-1-sultan@kerneltoast.com> References: <20210918233920.9174-1-sultan@kerneltoast.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=gya7g2De; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 50E72D0000AD X-Stat-Signature: kzth9j98z8gcfn944kdbx93ey9hbbn5i X-HE-Tag: 1632091206-747998 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 18 Sep 2021 16:39:20 -0700 Sultan Alsawaf wrote: > The OOM reaper thread uses wait_event_freezable() without actually being > marked as freezable. Fix it by adding a set_freezable() call. Oh. What are the runtime effects of this defect?