Re: [PATCH v2 02/13] mm: memcontrol: prepare objcg API for non-kmem usage

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3317 bytes --]

Hi Muchun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tj-cgroup/for-next]
[also build test ERROR on linus/master v5.15-rc1 next-20210917]
[cannot apply to hnaz-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-next
config: x86_64-randconfig-r003-20210916 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c8b3d7d6d6de37af68b2f379d0e37304f78e115f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a0025824ba235ffffd469c7cf95e6eb3004bb3a1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Muchun-Song/Use-obj_cgroup-APIs-to-charge-the-LRU-pages/20210916-215452
        git checkout a0025824ba235ffffd469c7cf95e6eb3004bb3a1
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   vmlinux.o: warning: objtool: sm4_aesni_avx_crypt8()+0x8: sibling call from callable instruction with modified stack frame
   vmlinux.o: warning: objtool: asm_load_gs_index()+0x10: return with modified stack frame
   vmlinux.o: warning: objtool: .fixup+0x0: stack state mismatch: cfa1=4+8 cfa2=5+16
>> ld.lld: error: undefined symbol: obj_cgroup_uncharge_pages
   >>> referenced by memcontrol.c:299 (mm/memcontrol.c:299)
   >>>               vmlinux.o:(obj_cgroup_release)
--
>> mm/memcontrol.c:266:13: warning: function 'obj_cgroup_uncharge_pages' has internal linkage but is not defined [-Wundefined-internal]
   static void obj_cgroup_uncharge_pages(struct obj_cgroup *objcg,
               ^
   mm/memcontrol.c:299:3: note: used here
                   obj_cgroup_uncharge_pages(objcg, nr_pages);
                   ^
   mm/memcontrol.c:766:20: warning: unused function 'mod_objcg_mlstate' [-Wunused-function]
   static inline void mod_objcg_mlstate(struct obj_cgroup *objcg,
                      ^
   mm/memcontrol.c:942:29: warning: unused function 'memcg_kmem_bypass' [-Wunused-function]
   static __always_inline bool memcg_kmem_bypass(void)
                               ^
   mm/memcontrol.c:2102:33: warning: unused function 'get_obj_stock' [-Wunused-function]
   static inline struct obj_stock *get_obj_stock(unsigned long *pflags)
                                   ^
   mm/memcontrol.c:2118:20: warning: unused function 'put_obj_stock' [-Wunused-function]
   static inline void put_obj_stock(unsigned long flags)
                      ^
   5 warnings generated.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34224 bytes --]