From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0DFC433F5 for ; Thu, 16 Sep 2021 12:39:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 505836103B for ; Thu, 16 Sep 2021 12:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 505836103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EA49D6B0071; Thu, 16 Sep 2021 08:38:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D45F06B0073; Thu, 16 Sep 2021 08:38:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C48EA6B0074; Thu, 16 Sep 2021 08:38:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id A2A536B0071 for ; Thu, 16 Sep 2021 08:38:58 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3B976181AF5C1 for ; Thu, 16 Sep 2021 12:38:58 +0000 (UTC) X-FDA: 78593391156.33.69BB59A Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf07.hostedemail.com (Postfix) with ESMTP id 6B60910000AE for ; Thu, 16 Sep 2021 12:38:57 +0000 (UTC) Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H9Gnr2pMJzWBdJ; Thu, 16 Sep 2021 20:37:52 +0800 (CST) Received: from huawei.com (10.175.124.27) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Thu, 16 Sep 2021 20:38:53 +0800 From: Miaohe Lin To: , , , , , CC: , , , , , , , , , , Subject: [PATCH 1/5] mm, slub: fix two bugs in slab_debug_trace_open() Date: Thu, 16 Sep 2021 20:39:16 +0800 Message-ID: <20210916123920.48704-2-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210916123920.48704-1-linmiaohe@huawei.com> References: <20210916123920.48704-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: wyy5wjspefdsj7wesb1hgo3f4wohqoqz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6B60910000AE X-HE-Tag: 1631795937-76864 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It's possible that __seq_open_private() will return NULL. So we should check t before using lest dereferencing NULL pointer. And in error paths, we forgot to release private buffer via seq_release_private(). Memory will leak in these paths. Fixes: 64dd68497be7 ("mm: slub: move sysfs slab alloc/free interfaces to = debugfs") Signed-off-by: Miaohe Lin --- mm/slub.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 3d2025f7163b..ed160b6c54f8 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6108,9 +6108,14 @@ static int slab_debug_trace_open(struct inode *ino= de, struct file *filep) struct kmem_cache *s =3D file_inode(filep)->i_private; unsigned long *obj_map; =20 + if (!t) + return -ENOMEM; + obj_map =3D bitmap_alloc(oo_objects(s->oo), GFP_KERNEL); - if (!obj_map) + if (!obj_map) { + seq_release_private(inode, filep); return -ENOMEM; + } =20 if (strcmp(filep->f_path.dentry->d_name.name, "alloc_traces") =3D=3D 0) alloc =3D TRACK_ALLOC; @@ -6119,6 +6124,7 @@ static int slab_debug_trace_open(struct inode *inod= e, struct file *filep) =20 if (!alloc_loc_track(t, PAGE_SIZE / sizeof(struct location), GFP_KERNEL= )) { bitmap_free(obj_map); + seq_release_private(inode, filep); return -ENOMEM; } =20 --=20 2.23.0