From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFD8C433FE for ; Thu, 16 Sep 2021 00:17:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 212DF611C8 for ; Thu, 16 Sep 2021 00:17:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 212DF611C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 801856B0071; Wed, 15 Sep 2021 20:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B06E6B0072; Wed, 15 Sep 2021 20:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69F756B0073; Wed, 15 Sep 2021 20:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 5793F6B0071 for ; Wed, 15 Sep 2021 20:17:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EC1CD181B2E32 for ; Thu, 16 Sep 2021 00:17:13 +0000 (UTC) X-FDA: 78591521946.14.68F37CB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id A2853B000187 for ; Thu, 16 Sep 2021 00:17:13 +0000 (UTC) Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D365610A2; Thu, 16 Sep 2021 00:17:11 +0000 (UTC) Date: Wed, 15 Sep 2021 20:17:09 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Linus Torvalds , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Subject: Re: [PATCH v3 3/3] bootconfig: Free xbc_data in xbc_destroy_all() Message-ID: <20210915201709.1406426a@oasis.local.home> In-Reply-To: <20210916090503.c9d8209e8c88e9c4c7d3072c@kernel.org> References: <163171196689.590070.15063104707696447188.stgit@devnote2> <163171199244.590070.6356174550728998874.stgit@devnote2> <20210915102354.2841798d@oasis.local.home> <20210916090503.c9d8209e8c88e9c4c7d3072c@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 3bukzpnmr5x4zzi8soj3fhwr3zj8quez Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of "SRS0=EKR5=OG=goodmis.org=rostedt@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=EKR5=OG=goodmis.org=rostedt@kernel.org" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A2853B000187 X-HE-Tag: 1631751433-197132 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 16 Sep 2021 09:05:03 +0900 Masami Hiramatsu wrote: > Ah, it is my policy that the error or information message is shown > by caller (since caller can also ignore that, e.g. passing the > testing data), not from the library code. > I learned that from perf-probe and ftrace, sometimes the library > code reused in unexpected way. So I decided to decouple the > generating error message and showing it. OK, then we can just pass the number of nodes allocated via a pointer to an integer. Thanks! -- Steve