From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEA0C433EF for ; Wed, 15 Sep 2021 13:52:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D74861250 for ; Wed, 15 Sep 2021 13:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D74861250 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 97FD5900003; Wed, 15 Sep 2021 09:52:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92E13900002; Wed, 15 Sep 2021 09:52:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 843D9900003; Wed, 15 Sep 2021 09:52:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 7638D900002 for ; Wed, 15 Sep 2021 09:52:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2E147180ACC20 for ; Wed, 15 Sep 2021 13:52:05 +0000 (UTC) X-FDA: 78589946610.06.FD1F69D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id 9783EB000186 for ; Wed, 15 Sep 2021 13:52:04 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C0A0867357; Wed, 15 Sep 2021 15:52:01 +0200 (CEST) Date: Wed, 15 Sep 2021 15:52:01 +0200 From: Christoph Hellwig To: Vasily Averin Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel@openvz.org Subject: Re: [PATCH mm] mm/vmalloc: repair warn_alloc()s in __vmalloc_area_node() Message-ID: <20210915135201.GB14571@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9783EB000186 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: 73pso34twfsci6554fgyb96oe3htmz6s X-HE-Tag: 1631713924-441585 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 15, 2021 at 02:43:10PM +0300, Vasily Averin wrote: > Commit f255935b9767 ("mm: cleanup the gfp_mask handling in > __vmalloc_area_node") added __GFP_NOWARN to gfp_mask unconditionally > however it disabled all output inside warn_alloc() call. > This patch saves original gfp_mask and provides it to all warn_alloc() calls. > > Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node") > Cc: Christoph Hellwig > > Signed-off-by: Vasily Averin Looks fine, thanks. Reviewed-by: Christoph Hellwig