From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4ACEC433EF for ; Wed, 15 Sep 2021 01:45:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 49E1561214 for ; Wed, 15 Sep 2021 01:45:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49E1561214 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DED306B0073; Tue, 14 Sep 2021 21:45:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9D44900003; Tue, 14 Sep 2021 21:45:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8B23900002; Tue, 14 Sep 2021 21:45:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id B96956B0073 for ; Tue, 14 Sep 2021 21:45:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 82B558249980 for ; Wed, 15 Sep 2021 01:45:54 +0000 (UTC) X-FDA: 78588116628.01.F32546D Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id 45E38801A89F for ; Wed, 15 Sep 2021 01:45:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4E47260F6C; Wed, 15 Sep 2021 01:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631670353; bh=xMCS2nurSB8LZcGtKXwO1JEEW4Gr1XYO8f1Eg2h7Llo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eq7ZBiU+azjY2HTf8eCwJpXY8Lt51e/wJxrpxUJM4mxNP1LMnWqbZew2Nicbd0OG7 5HV9KsfBbFaviO0slh0yuCd87SftqUNHruRkB3a8fAnwiZ1c+J9XjHHTrulZqNFfUP zCpsS1TRJuyGyovE+gFN+8bKwJbZfUl79Agq1XCBfJP1lQHKjvl1obQL0R6uRwkyJS KTwH3nnrB7RO1xVJVvJ31EvyMkTVLRQLJ1x6xG153ad6rFDJ/RvcEpPFzeguNwBR5f xdsThmNWN8SorWHcoV2XyCMquaytxvygaNmJttXtBGrIa9Zp506AASugD2I2NetwEw LhlQHH4raVqrQ== Date: Wed, 15 Sep 2021 10:45:50 +0900 From: Masami Hiramatsu To: Linus Torvalds Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Subject: Re: [PATCH v2 4/5] bootconfig: Free copied bootconfig data after boot Message-Id: <20210915104550.99a35ef0f1b0e944febf3293@kernel.org> In-Reply-To: References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166721027.510331.6820619440348067061.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 45E38801A89F Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=eq7ZBiU+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of mhiramat@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mhiramat@kernel.org X-Stat-Signature: 3x74bwmi4fxrbhymwg898uqbjccx16xf X-HE-Tag: 1631670354-290190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Sep 2021 18:13:51 -0700 Linus Torvalds wrote: > On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > > > Free copied bootconfig data after booting kernel because that > > data will not be used anymore. > > Don't do this. > > You have already passed in that 'copy' to the xbc code, and > xbc_destroy_all() should just free it. > > Don't add new pointless variables to keep track of state that somebody > else already keeps track of. Ah, OK. So when I pass the copy, the ownership should be passed too. Thank you, > > Linus -- Masami Hiramatsu