From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47654C433EF for ; Wed, 15 Sep 2021 01:44:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA6DA61242 for ; Wed, 15 Sep 2021 01:44:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA6DA61242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EDAAA6B0071; Tue, 14 Sep 2021 21:44:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E87726B0072; Tue, 14 Sep 2021 21:44:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D75D76B0073; Tue, 14 Sep 2021 21:44:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id C50E86B0071 for ; Tue, 14 Sep 2021 21:44:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 60B772FD70 for ; Wed, 15 Sep 2021 01:44:57 +0000 (UTC) X-FDA: 78588114234.01.215FF83 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP id 17394505EFA8 for ; Wed, 15 Sep 2021 01:44:56 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 52A9160F6C; Wed, 15 Sep 2021 01:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631670294; bh=AHU95kX8K9H+u3hfWH31TWVQUq+XxncGivmhHM7Hmcw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Gxthpra9GO98emsJK8Oxl33MSQDeMbMNlPUs5DkQpY96vcnT/xlD4h3bQvSAfM55A tnL5aBW6x/gUBk2AzkmsONYVR1rz62WQ1jAewsbBEEEz0bIOgiFKuVo7uXVhaN1S/Z 9OhMCnwzd8SWS7xSSzZleqUmvGbo87k32+6F4Q+h1FrnZQXpCwEDcwPrRX7HBIhNAQ F4Q9C2ZvewCesEfIjFwgo1jxBskDCNWbfnU5kxAr6PQRxRjl87MnMUC7+k5CZVlyH3 1cD8gAkld2gvLPbE/tERLZZriywYTV0A7fDawDnJNem+SDVaWmX/J3tT/8TgbLzOlc FIUkNG9HRTxwA== Date: Wed, 15 Sep 2021 10:44:52 +0900 From: Masami Hiramatsu To: Linus Torvalds Cc: Steven Rostedt , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Linux-MM , Vlastimil Babka Subject: Re: [PATCH v2 1/5] bootconfig: Fix to check the xbc_node is used before free it Message-Id: <20210915104452.9a3cfd0648a4edeca4583c84@kernel.org> In-Reply-To: References: <163166717752.510331.12843735095061762373.stgit@devnote2> <163166718582.510331.11732633028925882626.stgit@devnote2> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Gxthpra9; spf=pass (imf05.hostedemail.com: domain of mhiramat@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: mi8odnqowmoesubar3i6jyjh3nrcchqp X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 17394505EFA8 X-HE-Tag: 1631670296-690134 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Sep 2021 18:12:28 -0700 Linus Torvalds wrote: > On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu wrote: > > > > Fix to check the xbc_node is used before calling memblock_free() > > because passing NULL to phys_addr() will cause a panic. > > No. > > That's the previous bad situation. > > The whole point of memblock_free_ptr() is that it actually acts the > way a memory freeing function *should*, and has no problems with NULL > pointers. Oops, sorry. Please drop it. > > > - Rebase on top of Linus tree. > > Please don't do a mindless rebase, take the actual changes into account. Sorry about that. I missed the change. Thank you, > > Linus -- Masami Hiramatsu