From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C14C433F5 for ; Wed, 15 Sep 2021 08:49:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7878B60527 for ; Wed, 15 Sep 2021 08:49:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7878B60527 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0CC5A6B0071; Wed, 15 Sep 2021 04:49:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 055B26B0072; Wed, 15 Sep 2021 04:49:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5F63900002; Wed, 15 Sep 2021 04:49:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id D49116B0071 for ; Wed, 15 Sep 2021 04:49:22 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A1F043C7A0 for ; Wed, 15 Sep 2021 08:49:22 +0000 (UTC) X-FDA: 78589183764.10.10CC6EC Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id 171D4D02E6A7 for ; Wed, 15 Sep 2021 08:49:21 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B324A67373; Wed, 15 Sep 2021 10:49:18 +0200 (CEST) Date: Wed, 15 Sep 2021 10:49:18 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , "axboe@kernel.dk" , "linux-block@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 01/17] mm: don't include in Message-ID: <20210915084918.GA25090@lst.de> References: <20210915064044.950534-1-hch@lst.de> <20210915064044.950534-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 171D4D02E6A7 Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: p4dd49r4qrfusozzr7m1x4b8dhpatnmb X-HE-Tag: 1631695761-42111 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 15, 2021 at 08:45:56AM +0000, Johannes Thumshirn wrote: > > index 5259edacde380..066a9118c3748 100644 > > --- a/drivers/gpu/drm/i915/i915_utils.h > > +++ b/drivers/gpu/drm/i915/i915_utils.h > > @@ -30,6 +30,7 @@ > > #include > > #include > > #include > > +#include > > > > struct drm_i915_private; > > struct timer_list; > > This one > > > diff --git a/lib/random32.c b/lib/random32.c > > index 4d0e05e471d72..a57a0e18819d0 100644 > > --- a/lib/random32.c > > +++ b/lib/random32.c > > @@ -39,6 +39,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > > > and this one look unrelated. .. but they aren't. All these headers indirectl pulled these headers in before and now don't. random32.c pulls in writeback.h through trace/events/random.h, which pulls in blk-cgroup.h, which pull in blkdev.h, which pulls in slab.h through some other weird twist of fate. The drm code also somehow manages to pull in writeback.h