From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45CBAC433F5 for ; Tue, 14 Sep 2021 23:45:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D559F6108F for ; Tue, 14 Sep 2021 23:45:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D559F6108F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 74D676B0072; Tue, 14 Sep 2021 19:45:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FCBF6B0073; Tue, 14 Sep 2021 19:45:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EC486B0074; Tue, 14 Sep 2021 19:45:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 51AF36B0072 for ; Tue, 14 Sep 2021 19:45:02 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 14848181EBF24 for ; Tue, 14 Sep 2021 23:45:02 +0000 (UTC) X-FDA: 78587812044.24.D411A8A Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id C1385B00009D for ; Tue, 14 Sep 2021 23:45:01 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4D1E2610D1; Tue, 14 Sep 2021 23:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631663097; bh=jPzXCbaYboqogHgyU4a5pn1KllvDy5UAWUWaY6rE2as=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p6f2Gt07SptLS5tCsam4bUpPP+zv/8SlZDlGFUQWkbk4L4ffFZ745e6rIWReqSg8V NygS9oUCLX7g6LUoZcIO4+2VFg3SR3zkHiBP39SB7Jx80xqNCeEn94sfHGoM2JwAY3 U/asZb3lkVDSv0o5qtgzw+I+PmHEoUfi83pzq5pyR7mQ/285U3/K9UvJDSXuxjBFLf NHPw/wIb62dnvgmMvNgvBQ98E3ab9IBHS0yrEhM3EJzJu7087oE02OVljZ/6Q1AP7y OAoWDT/C367QTEgP4CNEm8ACuqDwPHW9JystnNRrgGKyZaN5a8z6ZH9AVe3pWk7lea yzOyZi8dO56qA== Date: Wed, 15 Sep 2021 08:44:54 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Linus Torvalds , Mike Rapoport , Andrew Morton , LKML , Ingo Molnar , Masami Hiramatsu , Linux-MM , Vlastimil Babka Subject: Re: [GIT PULL] tracing: Fixes to bootconfig memory management Message-Id: <20210915084454.b72fcdd705e553aabe6bc44e@kernel.org> In-Reply-To: <20210914170553.7c1e1faa@oasis.local.home> References: <20210914105620.677b90e5@oasis.local.home> <20210914145953.189f15dc@oasis.local.home> <20210914170553.7c1e1faa@oasis.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p6f2Gt07; spf=pass (imf19.hostedemail.com: domain of mhiramat@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mhiramat@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C1385B00009D X-Stat-Signature: i9uaquepp6xmbmaqiuxfzw4bfgwmoegt X-HE-Tag: 1631663101-428268 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 14 Sep 2021 17:05:53 -0400 Steven Rostedt wrote: > On Tue, 14 Sep 2021 13:48:15 -0700 > Linus Torvalds wrote: > > > On Tue, Sep 14, 2021 at 12:38 PM Linus Torvalds > > wrote: > > > > > > So I'll do a minimal conversion that adds "memblock_free_ptr()" and > > > hope that people start using that. And then we can later try to move > > > "memblock_free()" to a name that isn't so misleading. > > > > Commit 77e02cf57b6c ("memblock: introduce saner 'memblock_free_ptr()' > > interface") should hopefully fix that panic that Vlastimil saw, and > > the kernel test robot report as well. > > > > And it should make it easy to cleanly fix that 'copy' leak too. > > > > Vlastimil, > > Can you confirm that Linus's changes addresses your issue? > > Masami, > > Care to rebase on top of Linus's change? Sure! and I found another memblock leak, so I'll add it too. Thank you! -- Masami Hiramatsu