From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9167FC433EF for ; Tue, 14 Sep 2021 11:52:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2BA36610A2 for ; Tue, 14 Sep 2021 11:52:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2BA36610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A96976B006C; Tue, 14 Sep 2021 07:52:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A467D6B0071; Tue, 14 Sep 2021 07:52:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BFE76B0072; Tue, 14 Sep 2021 07:52:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 7D3E16B006C for ; Tue, 14 Sep 2021 07:52:21 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 358282FD87 for ; Tue, 14 Sep 2021 11:52:21 +0000 (UTC) X-FDA: 78586016082.39.B59B7B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id DC5E430000A4 for ; Tue, 14 Sep 2021 11:52:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631620340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qBY2XNwXX1MA9VLSXKiCQE1n4LcmSBqUdBbPiBpddUA=; b=HfZ/XgMhjIa8+zSl/oevZasKQs1OcW4rpNysMpLGvT39tT5hpJfvV5pYUvfdND0W9DA229 BUi8ZkkDynu4IVCUMpM6VCpOXPor6SpGk6cOCNXazL3qwmDSqgAnKZaQYdCziMkDXZDkWn rm8Car2i2ISfbwfeOe90uhUTnfKJR6Q= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-f4WvxoHqPZmaN6qcu8LNpA-1; Tue, 14 Sep 2021 07:52:19 -0400 X-MC-Unique: f4WvxoHqPZmaN6qcu8LNpA-1 Received: by mail-wr1-f69.google.com with SMTP id g1-20020a5d64e1000000b0015e0b21ef04so1952704wri.17 for ; Tue, 14 Sep 2021 04:52:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qBY2XNwXX1MA9VLSXKiCQE1n4LcmSBqUdBbPiBpddUA=; b=zeYXJvBZ4Fi06PL/ipyma5OhaggWAA+1sJOw3HD/gDnTmu4AIJW5VMTvwFXr2VSg40 /ETwbejx7AyqJrr8oQlqRiXvnP84TxcxgYT6VkG3WdOlL1kVHwPa44tnAivrRhkZjNwr VdRK27BIridnD6DhzmPg0QWr/4oprp0VUlaMDosBJEEaOtlK8An8yPDSlKDQfjOnxAWe 1jGg5Cr4Kmuq1pG063VCP/jVT/N2HJc7MAsf2VoQtppRVNyDm5PQHThCsjE9pUy9RQlC H8puVhjMCL9Dp1wJmZ1ARLV4/676xiTOUP4g+pJUw51jQKi4FtSkCyZBfyZ7qD2yxLhW 71tg== X-Gm-Message-State: AOAM533cM8hnt1AwfshHfS6jvNAeDAqM7Dk9UyLH4/7GmqXC+ROrwVBU 0paPgkpwrS/c1+Cm8atobBU2abNQGVdMjHNcZ9yQOrESLdcjG8UrW+Uer0gguvwyKK/7mbdfcc5 JBwW26VjmCfM= X-Received: by 2002:a05:600c:a05:: with SMTP id z5mr1723616wmp.73.1631620338109; Tue, 14 Sep 2021 04:52:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiYlZHtMLRjzoVegHvs1Jq46SZ36SDV0xzz4EafT+Ga/oyoJS+AncArM4zwCppyvnbWFnkYg== X-Received: by 2002:a05:600c:a05:: with SMTP id z5mr1723592wmp.73.1631620337926; Tue, 14 Sep 2021 04:52:17 -0700 (PDT) Received: from redhat.com ([2.55.151.134]) by smtp.gmail.com with ESMTPSA id l21sm922488wmh.31.2021.09.14.04.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 04:52:17 -0700 (PDT) Date: Tue, 14 Sep 2021 07:52:13 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Jason Wang , "Rafael J. Wysocki" , Andrew Morton , Dan Williams , Hanjun Guo , Andy Shevchenko , virtualization@lists.linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH v4 3/3] virtio-mem: disallow mapping virtio-mem memory via /dev/mem Message-ID: <20210914075046-mutt-send-email-mst@kernel.org> References: <20210902160919.25683-1-david@redhat.com> <20210902160919.25683-4-david@redhat.com> <20210903025630-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DC5E430000A4 X-Stat-Signature: 14wpsq6p6ssj5osqou69ozsmq53aaa1a Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HfZ/XgMh"; spf=none (imf03.hostedemail.com: domain of mst@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1631620340-264196 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 11:45:25AM +0200, David Hildenbrand wrote: > On 03.09.21 09:02, Michael S. Tsirkin wrote: > > On Thu, Sep 02, 2021 at 06:09:19PM +0200, David Hildenbrand wrote: > > > We don't want user space to be able to map virtio-mem device memory > > > directly (e.g., via /dev/mem) in order to have guarantees that in a sane > > > setup we'll never accidentially access unplugged memory within the > > > device-managed region of a virtio-mem device, just as required by the > > > virtio-spec. > > > > > > As soon as the virtio-mem driver is loaded, the device region is visible > > > in /proc/iomem via the parent device region. From that point on user space > > > is aware of the device region and we want to disallow mapping anything > > > inside that region (where we will dynamically (un)plug memory) until > > > the driver has been unloaded cleanly and e.g., another driver might take > > > over. > > > > > > By creating our parent IORESOURCE_SYSTEM_RAM resource with > > > IORESOURCE_EXCLUSIVE, we will disallow any /dev/mem access to our > > > device region until the driver was unloaded cleanly and removed the > > > parent region. This will work even though only some memory blocks are > > > actually currently added to Linux and appear as busy in the resource tree. > > > > > > So access to the region from user space is only possible > > > a) if we don't load the virtio-mem driver. > > > b) after unloading the virtio-mem driver cleanly. > > > > > > Don't build virtio-mem if access to /dev/mem cannot be restricticted -- > > > if we have CONFIG_DEVMEM=y but CONFIG_STRICT_DEVMEM is not set. > > > > > > Reviewed-by: Dan Williams > > > Signed-off-by: David Hildenbrand > > > > > > > --- > > > drivers/virtio/Kconfig | 1 + > > > drivers/virtio/virtio_mem.c | 4 +++- > > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > > > index ce1b3f6ec325..ff80cd03f1d1 100644 > > > --- a/drivers/virtio/Kconfig > > > +++ b/drivers/virtio/Kconfig > > > @@ -101,6 +101,7 @@ config VIRTIO_MEM > > > depends on MEMORY_HOTPLUG_SPARSE > > > depends on MEMORY_HOTREMOVE > > > depends on CONTIG_ALLOC > > > + depends on !DEVMEM || STRICT_DEVMEM > > > help > > > This driver provides access to virtio-mem paravirtualized memory > > > devices, allowing to hotplug and hotunplug memory. > > > > It would be nicer if there was a symbol in the MEMORY_ namespace > > we can depend on exported by mm and depending on !DEVMEM || > > STRICT_DEVMEM. > > > > E.g. > > > > config MEMORY_EXCLUSIVE > > def_bool y > > depends on !DEVMEM || STRICT_DEVMEM > > > > and then in virtio > > depends on MEMORY_EXCLUSIVE > > > > > > Yes, but I'm not able to come up with an expressive name. MEMORY_EXCLUSIVE > can be highly misleading ... I mean ... it enables IORESOURCE_EXCLUSIVE ... but ok ... MEMORY_EXCLUSIVE_KERNEL_MAP ? > > > the virtio change itself is ok though: > > > > Acked-by: Michael S. Tsirkin > > Thanks! > > > -- > Thanks, > > David / dhildenb