linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: SeongJae Park <sj38.park@gmail.com>
To: Adam Borowski <kilobyte@angband.pl>
Cc: SeongJae Park <sjpark@amazon.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm/damon: don't use strnlen() with known-bogus source length
Date: Mon, 13 Sep 2021 08:14:30 +0000	[thread overview]
Message-ID: <20210913081430.17201-1-sjpark@amazon.de> (raw)
In-Reply-To: <20210912204447.10427-1-kilobyte@angband.pl>

From: SeongJae Park <sjpark@amazon.de>

Hi Adam,

On Sun, 12 Sep 2021 22:44:47 +0200 Adam Borowski <kilobyte@angband.pl> wrote:

> gcc knows the true length too, and rightfully complains.
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>
> ---
>  mm/damon/dbgfs-test.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Thank you for the patch, and the change looks good to me.  However, I couldn't
cleanly apply the patch in a single step.

    $ git am the_patch_adam.eml
    Applying: mm/damon: don't use strnlen() with known-bogus source length
    error: patch failed: mm/damon/dbgfs-test.h:20
    error: mm/damon/dbgfs-test.h: patch does not apply
    Patch failed at 0001 mm/damon: don't use strnlen() with known-bogus source length
    Use 'git am --show-current-patch' to see the failed patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

I saved your mail to 'the_patch_adam.eml' directly from my inbox instead of
downloading it from lore using b4, as your mail doesn't appear on lore.  If I'm
not missing something, coule you please double check and resend?


Thanks,
SJ


           reply	other threads:[~2021-09-13  8:14 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210912204447.10427-1-kilobyte@angband.pl>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210913081430.17201-1-sjpark@amazon.de \
    --to=sj38.park@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kilobyte@angband.pl \
    --cc=linux-mm@kvack.org \
    --cc=sjpark@amazon.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox