From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 974AFC433EF for ; Mon, 6 Sep 2021 14:03:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2E9F60F45 for ; Mon, 6 Sep 2021 14:03:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2E9F60F45 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 848796B0072; Mon, 6 Sep 2021 10:03:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F81D6B0073; Mon, 6 Sep 2021 10:03:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C05A900002; Mon, 6 Sep 2021 10:03:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id 5DCE16B0072 for ; Mon, 6 Sep 2021 10:03:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F2CD71DAEE for ; Mon, 6 Sep 2021 14:03:31 +0000 (UTC) X-FDA: 78557316264.28.4019529 Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf19.hostedemail.com (Postfix) with ESMTP id 6BF1BB0000AD for ; Mon, 6 Sep 2021 14:03:30 +0000 (UTC) Received: from ThinkPad-W520 (unknown [119.4.66.120]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9DxpeWbHzZhii4AAA--.327S2; Mon, 06 Sep 2021 22:03:10 +0800 (CST) Date: Mon, 6 Sep 2021 22:03:07 +0800 From: Huang Pei To: "Maciej W. Rozycki" Cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , Steven Rostedt , Jisheng Zhang , Masami Hiramatsu Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64 Message-ID: <20210906140307.cnj7iv567aibvhzr@ThinkPad-W520> References: <20210904151218.10167-1-huangpei@loongson.cn> <20210905004810.5783639.10620.10055@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CM-TRANSID:AQAAf9DxpeWbHzZhii4AAA--.327S2 X-Coremail-Antispam: 1UD129KBjvJXoWxCr43WryUCw4UJrW5GF1rWFg_yoWrAFyxpF yDCa97Kayqya48J34DCF1vvr1Yvr4YkrWakF1qkrWjyFyrtr18ZrsFkr9aqFyxt3W5Gw4x XFy7Cwn8K3Z7Zw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvl14x267AKxVW5JVWrJwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r1j6r1xM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcVAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kI c2xKxwCY02Avz4vE14v_Xryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrZr1j6s0DMIIF0xvE x4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvj DU0xZFpf9x0JUBOJnUUUUU= X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6BF1BB0000AD X-Stat-Signature: 9rzzkwccu1pn43ok6j4kxqi1jjibrnta X-HE-Tag: 1630937010-131788 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.022282, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 06, 2021 at 01:08:02PM +0200, Maciej W. Rozycki wrote: > On Sun, 5 Sep 2021, =E9=BB=84=E6=B2=9B wrote: >=20 > > You mean including =C2=A0asm/asm.h?=C2=A0 > >=20 > > or redefine LONG_ADDU as ** "addu " ** in asm/llsc.h? >=20 > Use the existing macros, they're there for this purpose and widely use= d=20 > throughout the port already. >=20 > Maciej diff --git a/arch/mips/include/asm/local.h b/arch/mips/include/asm/local.= h index 3c6db82ee0a6..551d8ba09cd7 100644 --- a/arch/mips/include/asm/local.h +++ b/arch/mips/include/asm/local.h @@ -9,6 +9,7 @@ #include #include #include +#include =20 typedef struct { @@ -40,10 +41,10 @@ static __inline__ long local_add_return(long i, local= _t * l) " .set arch=3Dr4000 \n" __SYNC(full, loongson3_war) " \n" "1:" __LL "%1, %2 # local_add_return \n" - __ADDU "%0, %1, %3 \n" + " LONG_ADDU %0, %1, %3 \n" __SC "%0, %2 \n" " beqzl %0, 1b \n" - __ADDU "%0, %1, %3 \n" + " LONG_ADDU %0, %1, %3 \n" " .set pop \n" : "=3D&r" (result), "=3D&r" (temp), "=3Dm" (l->a.counter) : "Ir" (i), "m" (l->a.counter) @@ -56,10 +57,10 @@ static __inline__ long local_add_return(long i, local= _t * l) " .set "MIPS_ISA_ARCH_LEVEL" \n" __SYNC(full, loongson3_war) " \n" "1:" __LL "%1, %2 # local_add_return \n" - __ADDU "%0, %1, %3 \n" + " LONG_ADDU %0, %1, %3 \n" __SC "%0, %2 \n" " beqz %0, 1b \n" - __ADDU "%0, %1, %3 \n" + " LONG_ADDU %0, %1, %3 \n" " .set pop \n" : "=3D&r" (result), "=3D&r" (temp), "=3Dm" (l->a.counter) : "Ir" (i), "m" (l->a.counter) @@ -89,10 +90,10 @@ static __inline__ long local_sub_return(long i, local= _t * l) " .set arch=3Dr4000 \n" __SYNC(full, loongson3_war) " \n" "1:" __LL "%1, %2 # local_sub_return \n" - __SUBU "%0, %1, %3 \n" + " LONG_SUBU %0, %1, %3 \n" __SC "%0, %2 \n" " beqzl %0, 1b \n" - __SUBU "%0, %1, %3 \n" + " LONG_SUBU %0, %1, %3 \n" " .set pop \n" : "=3D&r" (result), "=3D&r" (temp), "=3Dm" (l->a.counter) : "Ir" (i), "m" (l->a.counter) @@ -105,10 +106,10 @@ static __inline__ long local_sub_return(long i, loc= al_t * l) " .set "MIPS_ISA_ARCH_LEVEL" \n" __SYNC(full, loongson3_war) " \n" "1:" __LL "%1, %2 # local_sub_return \n" - __SUBU "%0, %1, %3 \n" + " LONG_SUBU %0, %1, %3 \n" __SC "%0, %2 \n" " beqz %0, 1b \n" - __SUBU "%0, %1, %3 \n" + " LONG_SUBU %0, %1, %3 \n" " .set pop \n" : "=3D&r" (result), "=3D&r" (temp), "=3Dm" (l->a.counter) : "Ir" (i), "m" (l->a.counter) || make[1]: Entering directory '/home/hp/projects/Linux/temp/out_stable_l= oongson' || GEN Makefile || Checking missing-syscalls for N32 || CALL /home/hp/projects/Linux/temp/linux-stable/scripts/checksysca= lls.sh || Checking missing-syscalls for O32 || CALL /home/hp/projects/Linux/temp/linux-stable/scripts/checksysca= lls.sh || CALL /home/hp/projects/Linux/temp/linux-stable/scripts/checksysca= lls.sh || CALL /home/hp/projects/Linux/temp/linux-stable/scripts/atomic/che= ck-atomics.sh || CC kernel/trace/ring_buffer.o || {standard input}: Assembler messages: {standard input}|11389| Error: unrecognized opcode `long_addu $6,$3,$2' {standard input}|11392| Error: unrecognized opcode `long_addu $6,$3,$2' {standard input}|11404| Error: unrecognized opcode `long_addu $5,$7,$2' {standard input}|11407| Error: unrecognized opcode `long_addu $5,$7,$2' {standard input}|12354| Error: unrecognized opcode `long_addu $20,$3,$2' {standard input}|12357| Error: unrecognized opcode `long_addu $20,$3,$2' /home/hp/projects/Linux/temp/linux-stable/scripts/Makefile.build|279| rec= ipe for target 'kernel/trace/ring_buffer.o' failed || make[3]: *** [kernel/trace/ring_buffer.o] Error 1 /home/hp/projects/Linux/temp/linux-stable/scripts/Makefile.build|496| rec= ipe for target 'kernel/trace' failed || make[2]: *** [kernel/trace] Error 2 /home/hp/projects/Linux/temp/linux-stable/Makefile|1805| recipe for targe= t 'kernel' failed || make[1]: *** [kernel] Error 2 || make[1]: Leaving directory '/home/hp/projects/Linux/temp/out_stable_lo= ongson' /home/hp/projects/Linux/temp/linux-stable/Makefile|185| recipe for target= '__sub-make' failed || make: *** [__sub-make] Error 2 Any better idea?