From: 黄沛 <huangpei@loongson.cn>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
ambrosehua@gmail.com, Bibo Mao <maobibo@loongson.cn>,
linux-mips@vger.kernel.org, linux-arch@vger.kernel.org,
linux-mm@kvack.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Paul Burton <paulburton@kernel.org>,
Li Xuefeng <lixuefeng@loongson.cn>,
Yang Tiezhu <yangtiezhu@loongson.cn>,
Gao Juxin <gaojuxin@loongson.cn>,
Huacai Chen <chenhuacai@loongson.cn>,
Jinyang He <hejinyang@loongson.cn>,
Steven Rostedt <rostedt@goodmis.org>,
Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64
Date: Sun, 05 Sep 2021 08:48:10 +0800 [thread overview]
Message-ID: <20210905004810.5783639.10620.10055@loongson.cn> (raw)
In-Reply-To: <alpine.DEB.2.21.2109041955310.38640@angie.orcam.me.uk>
You mean including asm/asm.h?
or redefine LONG_ADDU as ** "addu " ** in asm/llsc.h?
本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。
This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
Original Message
From: Maciej W. Rozycki
Sent: 2021年9月5日星期日 1:58
To: Huang Pei
Cc: Thomas Bogendoerfer; ambrosehua@gmail.com; Bibo Mao; linux-mips@vger.kernel.org; linux-arch@vger.kernel.org; linux-mm@kvack.org; Jiaxun Yang; Paul Burton; Li Xuefeng; Yang Tiezhu; Gao Juxin; Huacai Chen; Jinyang He; Steven Rostedt; Jisheng Zhang; Masami Hiramatsu
Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64
On Sat, 4 Sep 2021, Huang Pei wrote:
> diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h
> index ec09fe5d6d6c..788e26ad7fca 100644
> --- a/arch/mips/include/asm/llsc.h
> +++ b/arch/mips/include/asm/llsc.h
> @@ -16,11 +16,15 @@
> #define __SC "sc "
> #define __INS "ins "
> #define __EXT "ext "
> +#define __ADDU "addu "
> +#define __SUBU "subu "
> #elif _MIPS_SZLONG == 64
> #define __LL "lld "
> #define __SC "scd "
> #define __INS "dins "
> #define __EXT "dext "
> +#define __ADDU "daddu "
> +#define __SUBU "dsubu "
Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)?
Maciej
next prev parent reply other threads:[~2021-09-05 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 15:12 Huang Pei
2021-09-04 17:57 ` Maciej W. Rozycki
2021-09-05 0:48 ` 黄沛 [this message]
2021-09-06 11:08 ` Maciej W. Rozycki
2021-09-06 14:03 ` Huang Pei
2021-09-06 16:29 ` Maciej W. Rozycki
[not found] ` <6113C299-3E26-4445-97FD-32690FD91C95@loongson.cn>
2021-09-07 10:00 ` Maciej W. Rozycki
2021-09-08 8:15 ` 黄沛
2021-09-04 18:50 ` kernel test robot
2021-09-04 19:10 ` kernel test robot
2021-09-05 3:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210905004810.5783639.10620.10055@loongson.cn \
--to=huangpei@loongson.cn \
--cc=Jisheng.Zhang@synaptics.com \
--cc=ambrosehua@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=gaojuxin@loongson.cn \
--cc=hejinyang@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=macro@orcam.me.uk \
--cc=maobibo@loongson.cn \
--cc=mhiramat@kernel.org \
--cc=paulburton@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox