From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE2EC4320E for ; Thu, 2 Sep 2021 14:03:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69560610D2 for ; Thu, 2 Sep 2021 14:03:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 69560610D2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BC80C6B006C; Thu, 2 Sep 2021 10:03:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B50D96B0071; Thu, 2 Sep 2021 10:03:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A18776B0072; Thu, 2 Sep 2021 10:03:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 8DAF36B006C for ; Thu, 2 Sep 2021 10:03:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1B8732BA90 for ; Thu, 2 Sep 2021 14:03:40 +0000 (UTC) X-FDA: 78542801400.20.9F63038 Received: from outbound-smtp17.blacknight.com (outbound-smtp17.blacknight.com [46.22.139.234]) by imf17.hostedemail.com (Postfix) with ESMTP id 68350F0003AF for ; Thu, 2 Sep 2021 14:03:39 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp17.blacknight.com (Postfix) with ESMTPS id 74C601C4C06 for ; Thu, 2 Sep 2021 15:03:37 +0100 (IST) Received: (qmail 4898 invoked from network); 2 Sep 2021 14:03:37 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 2 Sep 2021 14:03:37 -0000 Date: Thu, 2 Sep 2021 15:03:36 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] mm/page_alloc.c: fix obsolete comment in free_pcppages_bulk() Message-ID: <20210902140336.GL4128@techsingularity.net> References: <20210902121242.41607-1-linmiaohe@huawei.com> <20210902121242.41607-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210902121242.41607-4-linmiaohe@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.234 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 68350F0003AF X-Stat-Signature: kgk34p6t6865t4wi779cg1qarces9wj3 X-HE-Tag: 1630591419-413504 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 02, 2021 at 08:12:40PM +0800, Miaohe Lin wrote: > The second two paragraphs about "all pages pinned" and pages_scanned is > obsolete. And There are PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP orders > in pcp. So the same order assumption is not held now. > > Signed-off-by: Miaohe Lin Acked-by: Mel Gorman -- Mel Gorman SUSE Labs