From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F76C4320A for ; Wed, 1 Sep 2021 15:14:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 21D2661090 for ; Wed, 1 Sep 2021 15:14:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 21D2661090 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1EFA96B006C; Wed, 1 Sep 2021 11:14:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19FDF6B0071; Wed, 1 Sep 2021 11:14:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0687B8D0001; Wed, 1 Sep 2021 11:14:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id EB78E6B006C for ; Wed, 1 Sep 2021 11:14:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 68839248A2 for ; Wed, 1 Sep 2021 15:14:16 +0000 (UTC) X-FDA: 78539350512.11.92CC93F Received: from outbound-smtp44.blacknight.com (outbound-smtp44.blacknight.com [46.22.136.52]) by imf09.hostedemail.com (Postfix) with ESMTP id 7F3593000108 for ; Wed, 1 Sep 2021 15:14:15 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp44.blacknight.com (Postfix) with ESMTPS id BB81DF8365 for ; Wed, 1 Sep 2021 16:14:13 +0100 (IST) Received: (qmail 19088 invoked from network); 1 Sep 2021 15:14:13 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 1 Sep 2021 15:14:13 -0000 Date: Wed, 1 Sep 2021 16:14:11 +0100 From: Mel Gorman To: Miaohe Lin Cc: akpm@linux-foundation.org, vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] mm/page_alloc.c: remove obsolete comment in free_pcppages_bulk() Message-ID: <20210901151411.GH4128@techsingularity.net> References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-4-linmiaohe@huawei.com> <20210831133830.GE4128@techsingularity.net> <884a4b72-95ab-0fca-6c74-d67535048736@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <884a4b72-95ab-0fca-6c74-d67535048736@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.52 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Stat-Signature: 6pggagrhrjforjmdrpuwdors98o5pou4 X-Rspamd-Queue-Id: 7F3593000108 X-Rspamd-Server: rspam04 X-HE-Tag: 1630509255-273452 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 01, 2021 at 03:49:03PM +0800, Miaohe Lin wrote: > On 2021/8/31 21:38, Mel Gorman wrote: > > On Mon, Aug 30, 2021 at 10:10:48PM +0800, Miaohe Lin wrote: > >> It's also confusing now. Remove it. > >> > > > > Why is the whole comment obsolete? > > > > The second two paragraphs about "all pages pinned" and pages_scanned is > > obsolete and can go but the first paragraph is valid. > > > > I think the first paragraph is invalid due to the below statement: > "Assumes all pages on list are in same zone, and of same order." > There are NR_PCP_LISTS lists and PAGE_ALLOC_COSTLY_ORDER + 1 + NR_PCP_THP > orders in pcp. So I think it's obsolete. > Ah. > Should I delete this statement in the first paragraph only? > Remove ", and of same order" -- Mel Gorman SUSE Labs