From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0E1DC4320A for ; Tue, 31 Aug 2021 23:23:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E5BE60F91 for ; Tue, 31 Aug 2021 23:23:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E5BE60F91 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 50F966B006C; Tue, 31 Aug 2021 19:23:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BE4D6B0071; Tue, 31 Aug 2021 19:23:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 386508D0001; Tue, 31 Aug 2021 19:23:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 298BE6B006C for ; Tue, 31 Aug 2021 19:23:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D71EC181B048D for ; Tue, 31 Aug 2021 23:23:04 +0000 (UTC) X-FDA: 78536953488.07.0C5D9A6 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 93EC07001A08 for ; Tue, 31 Aug 2021 23:23:04 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id s10so2354984lfr.11 for ; Tue, 31 Aug 2021 16:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qTGMUJ1fnMBo+Q1kt2wvOXORnThBqbNZ7LIT9ecQXE4=; b=mER5XiOy8koaS6tZs5Ukk1lV155l26r6AQblG/hlIf0ZFf/+gW0mM16KEMts/pyGmA ilRwF+Z4fobIIzSuTSpXu33eLW6jkFJniOlhjt2hbdwlxgPpimuujwWKFM2TS+HEUVN9 LhNOezSMIVpxmqtKpJPIN904HC5vZoWULfSRKYezTueepxfIzQhdkCISGTJ1RQN+UC15 pTtKleTC00QRxfN+DoT5bvHjGkFoaujebReNJhvEk4cSVSMMZ+anYLaUeYFwYqSfASXh gCVnsEMoFaU0R5rHnxOsfbyk36zn7uexsEeE6kiidqNVD3f9w+tJXYVLRdTrKFzKCqmQ aoQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qTGMUJ1fnMBo+Q1kt2wvOXORnThBqbNZ7LIT9ecQXE4=; b=mYC0Uoeooa66tqTj0M0ZrU4jQ9GSDQNk2OTIhjpP40x/UkB5YSh8OD6njd2zQs8tro RLjDLFQjHqxuTKZBkcPlUCdekn/T1JBErTTU9IKe+eDu/JngOgfUsSvorpQ6DIL+j2dX sB61ehHn5N5Xzev69MXxe5l3XuxT/nkhOQQGjFmGFf8sqQvfYrPkTzVxY3qMz2ANjGhk S3K3kHOtaXnV/rBvD/WnOk7Y1nxan3dSuoGm/BfkgRCOELw95XTeqe9i80hWoT1LNmSJ 3OWom5w70zyqNm60B04GAg+H4yo9q4t667OvPYDlbdNOXZnnv3LfIpv09vwKz1keYJkm W0Dw== X-Gm-Message-State: AOAM533LYc6Dq9eDwJcFG65HrPNkQepp7OaJw53z+MbKi1F4qg7Uchy5 VJ2EVeA522h0JTMhyqm3ySY//Q== X-Google-Smtp-Source: ABdhPJycZ4wjWM84EJAwhegxR/lYKX5fd5MCyesH6ustBkwr//aIlTUP29jnFMcZJ7aYxNztQGRJIQ== X-Received: by 2002:a05:6512:e99:: with SMTP id bi25mr22941004lfb.486.1630452182771; Tue, 31 Aug 2021 16:23:02 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id k3sm2263434lja.109.2021.08.31.16.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 16:23:01 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id B7BC9102EFE; Wed, 1 Sep 2021 02:23:01 +0300 (+03) Date: Wed, 1 Sep 2021 02:23:01 +0300 From: "Kirill A. Shutemov" To: Qi Zheng Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com, david@redhat.com, vbabka@suse.cz, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH v2 1/2] mm: introduce pmd_install() helper Message-ID: <20210831232301.ilehcpc3n5bqodsz@box.shutemov.name> References: <20210831132111.85437-1-zhengqi.arch@bytedance.com> <20210831132111.85437-2-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210831132111.85437-2-zhengqi.arch@bytedance.com> Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=mER5XiOy; spf=none (imf02.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.49) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Stat-Signature: geowfe4f1ejsm9xcby9p93kpka96st3e X-Rspamd-Queue-Id: 93EC07001A08 X-Rspamd-Server: rspam04 X-HE-Tag: 1630452184-893292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 31, 2021 at 09:21:10PM +0800, Qi Zheng wrote: > Currently we have three times the same few lines repeated in the > code. Deduplicate them by newly introduced pmd_install() helper. > > Signed-off-by: Qi Zheng > Reviewed-by: David Hildenbrand > Reviewed-by: Muchun Song > --- > include/linux/mm.h | 1 + > mm/filemap.c | 11 ++--------- > mm/memory.c | 34 ++++++++++++++++------------------ > 3 files changed, 19 insertions(+), 27 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index a3cc83d64564..0af420a7e382 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2463,6 +2463,7 @@ static inline spinlock_t *pud_lock(struct mm_struct *mm, pud_t *pud) > return ptl; > } > > +extern void pmd_install(struct mm_struct *mm, pmd_t *pmd, pgtable_t *pte); > extern void __init pagecache_init(void); > extern void __init free_area_init_memoryless_node(int nid); > extern void free_initmem(void); mm/internal.h would be a better fit for the declaration. Otherwise: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov