From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F2ADC4338F for ; Wed, 25 Aug 2021 10:32:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20A8361037 for ; Wed, 25 Aug 2021 10:32:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 20A8361037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 81D058D0001; Wed, 25 Aug 2021 06:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6A56B0071; Wed, 25 Aug 2021 06:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66E018D0001; Wed, 25 Aug 2021 06:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 487616B006C for ; Wed, 25 Aug 2021 06:32:30 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CBC9B1800E394 for ; Wed, 25 Aug 2021 10:32:29 +0000 (UTC) X-FDA: 78513238818.40.4F9E8C7 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf27.hostedemail.com (Postfix) with ESMTP id 8BC4B70000A6 for ; Wed, 25 Aug 2021 10:32:29 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EE2FF61139; Wed, 25 Aug 2021 10:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629887548; bh=LBkEVhXk6nP+PCt46F0eZs1fuqXceK0E7MqW8V2Hc8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i/W8C9NRzVDY6t5f5deJdUpGbBfcDy5CEjRlBFvhSZ7Vo7ehuzLwapvfO7Ob5lnCk /ZQpwFPe1VDf2kihwnsKuQ3UkqehyM6Fq2/Z9zhiMnQh6A2BYuEDnrdFDQ6Mda5JV7 G47H96SylwEZ5Ae9Lx+2V1zkc/AKdhzRrI1Am6mAM8SBGLlgvc+SQBcc9UcgS2r+S4 ct+8jWCrHWG9UXjn6fTAfqCZjcjlVABTUXkkk65rESQqx1ftwYJsL0W6k1rQGI47/g PjsO6YYgU10R16U5oeZmMM7IFdN35oCYGB/11A5SgFecabqKQQ6E9uei2zLwv4Zh5Y qZZm5bUUkgOrw== Date: Wed, 25 Aug 2021 11:32:23 +0100 From: Will Deacon To: Catalin Marinas Cc: David Hildenbrand , Robin Murphy , Mike Rapoport , Alex Bee , Andrew Morton , Anshuman Khandual , Linux Kernel Mailing List , linux-mm@kvack.org, Linux ARM , Christoph Hellwig Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Message-ID: <20210825103223.GE24546@willie-the-truck> References: <20210824173741.GC623@arm.com> <0908ce39-7e30-91fa-68ef-11620f9596ae@arm.com> <60a11eba-2910-3b5f-ef96-97d4556c1596@redhat.com> <20210825102044.GA3420@arm.com> <20210825102856.GD24546@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825102856.GD24546@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="i/W8C9NR"; spf=pass (imf27.hostedemail.com: domain of will@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8BC4B70000A6 X-Stat-Signature: u9fn568c3ah3oxz6gnrh5hw6ws5aixex X-HE-Tag: 1629887549-121177 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 25, 2021 at 11:28:56AM +0100, Will Deacon wrote: > On Wed, Aug 25, 2021 at 11:20:46AM +0100, Catalin Marinas wrote: > > Given how later we are in the -rc cycle, I suggest we revert Anshuman's > > commit 16c9afc77660 ("arm64/mm: drop HAVE_ARCH_PFN_VALID") and try to > > assess the implications in 5.15 (the patch doesn't seem to have the > > arm64 maintainers' ack anyway ;)). > > I'll stick the revert (below) into kernelci now so we can get some coverage > in case it breaks something else. Bah, having said that... > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index fcb535560028..ee70f21a79d5 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -1463,15 +1463,6 @@ static inline int pfn_valid(unsigned long pfn) > { > struct mem_section *ms; > > - /* > - * Ensure the upper PAGE_SHIFT bits are clear in the > - * pfn. Else it might lead to false positives when > - * some of the upper bits are set, but the lower bits > - * match a valid pfn. > - */ > - if (PHYS_PFN(PFN_PHYS(pfn)) != pfn) > - return 0; > - I suppose we should leave this bit as-is, since the whole point here is trying to minimise the impact on other architectures. Will