From: Liu Zixian <liuzixian4@huawei.com>
To: <mike.kravetz@oracle.com>, <linux-mm@kvack.org>
Cc: <wuxu.wu@huawei.com>, <liuzixian4@huawei.com>
Subject: [PATCH] mm/hugetlb: initialize hugetlb_usage in mm_init
Date: Wed, 25 Aug 2021 16:37:04 +0800 [thread overview]
Message-ID: <20210825083704.744-1-liuzixian4@huawei.com> (raw)
After fork, the new process will get incorrect hugetlb_usage.
The reason is dup_mm copies old_mm to the new one and mm_init
does not init hugetlb_usage.
Fix this by adding hugetlb_count_init in mm_init.
Signed-off-by: Liu Zixian <liuzixian4@huawei.com>
---
include/linux/hugetlb.h | 5 +++++
kernel/fork.c | 3 +++
2 files changed, 8 insertions(+)
diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index f7ca1a387..66ceabd66 100644
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -858,6 +858,11 @@ static inline spinlock_t *huge_pte_lockptr(struct hstate *h,
void hugetlb_report_usage(struct seq_file *m, struct mm_struct *mm);
+static inline void hugetlb_count_init(struct mm_struct *mm)
+{
+ atomic_long_set(&mm->hugetlb_usage, 0);
+}
+
static inline void hugetlb_count_add(long l, struct mm_struct *mm)
{
atomic_long_add(l, &mm->hugetlb_usage);
diff --git a/kernel/fork.c b/kernel/fork.c
index bc94b2cc5..a9380081a 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1050,6 +1050,9 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
mm->pmd_huge_pte = NULL;
#endif
mm_init_uprobes_state(mm);
+#ifdef CONFIG_HUGETLB_PAGE
+ hugetlb_count_init(mm);
+#endif
if (current->mm) {
mm->flags = current->mm->flags & MMF_INIT_MASK;
--
2.18.1
reply other threads:[~2021-08-25 8:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825083704.744-1-liuzixian4@huawei.com \
--to=liuzixian4@huawei.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=wuxu.wu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox