From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8837C4338F for ; Tue, 24 Aug 2021 07:11:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A89061165 for ; Tue, 24 Aug 2021 07:11:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A89061165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 985F76B0072; Tue, 24 Aug 2021 03:11:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 935FC6B0073; Tue, 24 Aug 2021 03:11:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 824BE8D0001; Tue, 24 Aug 2021 03:11:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id 65F036B0072 for ; Tue, 24 Aug 2021 03:11:41 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F288E180AD820 for ; Tue, 24 Aug 2021 07:11:40 +0000 (UTC) X-FDA: 78509103960.06.24DFD4A Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf05.hostedemail.com (Postfix) with ESMTP id BB1DB5025109 for ; Tue, 24 Aug 2021 07:11:40 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id n12so11701046plf.4 for ; Tue, 24 Aug 2021 00:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4yj1MsIvR997A+hpDaBXq6r8GptVAD/IgfIuiHBhOHM=; b=QMMD8u5iwEL1arfrJUmL/M2KD/dalWvAbOL+9p9MTw9+KwpL8ulT0sz+GexEnLLMMQ 8Mqb9s84PgaP0SkvKCVD0C5+SjzTw1nja3LANWNRRXE/RoXjrg4YiywjNbsL8KSjKGgN js2lJLRQi4HtHpScoEa9hI1vMiDbskIyZ32f7BWv9JeabedKW6ffvZvcE3Ao3MxG/qEy YKDowB0/6IPPQPkiFKSG9WG9z9q8HxDrs0/0B6PNc0sj3j9Co6RUTFUGShWEeoQ3LWFi Lv0ENffwrfRBY/O0RgJAlmUJ2/7kAfgoos0lpDVbETBVkz5DH+OxK7sC2UhqTFqGVgzQ 5LJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4yj1MsIvR997A+hpDaBXq6r8GptVAD/IgfIuiHBhOHM=; b=cflUAnOGuNivHa957OUiUP+y4f3UzCtHV+UXP6PRrVaQEhSSvJup5pzC6ZKFjwNsvF iwuy0c8jcuDFcEbplFgudT86kz9iUEMcl9vXeY8tGANJrRYWeMSdrCWN4+Js2BqA/jWi K3Ft7WJZlD6eBMxGD4g9opuBrxsKZiWRtstH/gEfPMfKSNldpMmUqxUQK8P/9oxkkxta muPRaN7C7Df15NxHXqqa7MQ2A/u2O+eo7qwhwkV19TOcyNFsHFynbnN64yXlJVMSDGMy AusRu26fC8gk7dFcrws+Wo57B74r+h4AioV64uqDpLmsAyqZqGEC7wxWCDOBefr/WAOJ eCzg== X-Gm-Message-State: AOAM5300ozD1GKsxBxMU8NfHBVXShA4Eb1fPB1gN0jFOBLf9h6POhzTA LBRVKb3ylN81Yv87WfsY0cYQeg== X-Google-Smtp-Source: ABdhPJxQ1wFdYVovXT9dKl54dGmOA9fGkg7ufQa5T0lgmzW8BtSfW5LvKiAiavqRX+0VkHFFKK0fnQ== X-Received: by 2002:a17:90a:c705:: with SMTP id o5mr2866780pjt.55.1629789099672; Tue, 24 Aug 2021 00:11:39 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id s11sm10349375pfh.18.2021.08.24.00.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 00:11:39 -0700 (PDT) Date: Tue, 24 Aug 2021 12:41:37 +0530 From: Viresh Kumar To: "Chen, Rong A" Cc: kernel test robot , Thara Gopinath , clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 8440/9522] drivers/cpufreq/qcom-cpufreq-hw.c:294:3: warning: Value stored to 'opp' is never read [clang-analyzer-deadcode.DeadStores] Message-ID: <20210824071137.m7uhzwccfuhcrncf@vireshk-i7> References: <202108221933.WIgFqDfv-lkp@intel.com> <20210823065211.mzagmzexavwxu4vy@vireshk-i7> <38f16bcf-40bc-c400-ef64-da8e43b1135f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38f16bcf-40bc-c400-ef64-da8e43b1135f@intel.com> User-Agent: NeoMutt/20180716-391-311a52 Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=QMMD8u5i; spf=pass (imf05.hostedemail.com: domain of viresh.kumar@linaro.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=viresh.kumar@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BB1DB5025109 X-Stat-Signature: 1cmcgfhy3674ygfjmn5guhfcime4hak8 X-HE-Tag: 1629789100-910244 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24-08-21, 14:53, Chen, Rong A wrote: > > > On 8/23/2021 2:52 PM, Viresh Kumar wrote: > > On 22-08-21, 19:41, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > > head: 86ed57fd8c93fdfaabb4f58e78455180fa7d8a84 > > > commit: 86afc1df661a99dcd6b8d264cae171f1ead2b7b8 [8440/9522] cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support > > > config: arm-randconfig-c002-20210822 (attached as .config) > > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a83d99c55ebb14532c414066a5aa3bdb65389965) > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # install arm cross compiling tool for clang build > > > # apt-get install binutils-arm-linux-gnueabi > > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86afc1df661a99dcd6b8d264cae171f1ead2b7b8 > > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > > git fetch --no-tags linux-next master > > > git checkout 86afc1df661a99dcd6b8d264cae171f1ead2b7b8 > > > # save the attached .config to linux build tree > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > This doesn't look right, it says issues are with cpufreq-hw driver but > > points at hid-core ? > > Hi Viresh, > > The warning with the prefix ">>" is pointed to this commit, > others are only for reference. Fixed as this and pushed as Thara is away: diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 26293d3b15a4..a2be0df7e174 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -291,7 +291,7 @@ static void qcom_lmh_dcvs_notify(struct qcom_cpufreq_data *data) opp = dev_pm_opp_find_freq_floor(dev, &freq_hz); if (IS_ERR(opp) && PTR_ERR(opp) == -ERANGE) - opp = dev_pm_opp_find_freq_ceil(dev, &freq_hz); + dev_pm_opp_find_freq_ceil(dev, &freq_hz); throttled_freq = freq_hz / HZ_PER_KHZ; -- viresh