From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5054EC432BE for ; Mon, 23 Aug 2021 14:59:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 052BF6126A for ; Mon, 23 Aug 2021 14:59:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 052BF6126A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 984B0900015; Mon, 23 Aug 2021 10:58:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DB5290000F; Mon, 23 Aug 2021 10:58:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C7E790000A; Mon, 23 Aug 2021 10:58:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 10503900012 for ; Mon, 23 Aug 2021 10:58:44 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B4BB426DF7 for ; Mon, 23 Aug 2021 14:58:43 +0000 (UTC) X-FDA: 78506652126.31.C89935A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id 578146001993 for ; Mon, 23 Aug 2021 14:58:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4BBE020010; Mon, 23 Aug 2021 14:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629730722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOj9dYIIVDFZxt/Gcx+iwVlCy1GuCZGDYbzU8ga/jJI=; b=CzJ8lklmbjeEqaQRcdgwReztsoQa4fgA41BE5wuHUezpbgkCsOEA1q8/6uoQA6PJAZmif+ 6vIZrTs89PXkIuuw1wwhycyLpnyMfRlTrxJCtNcUPT1y5ZCjdWk7ozPlqJaSh7KECm0ZH0 uQbGUzaSCVDLfLNwjXb3wNyQ66GLE+0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629730722; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOj9dYIIVDFZxt/Gcx+iwVlCy1GuCZGDYbzU8ga/jJI=; b=/8SG6LYhJbdnACMvgSI9mEdV1WgLMAjwIwNrBoNqQAtuDxccD1sUN7qYzCjpnegmvR6Pe9 cgBkuPxFvIDhJvAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 24A4513BE0; Mon, 23 Aug 2021 14:58:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cNprCKK3I2EFQQAAMHmgww (envelope-from ); Mon, 23 Aug 2021 14:58:42 +0000 From: Vlastimil Babka To: Andrew Morton , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Galbraith , Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Jann Horn , Vlastimil Babka Subject: [PATCH v5 26/35] mm, slub: only disable irq with spin_lock in __unfreeze_partials() Date: Mon, 23 Aug 2021 16:58:17 +0200 Message-Id: <20210823145826.3857-27-vbabka@suse.cz> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210823145826.3857-1-vbabka@suse.cz> References: <20210823145826.3857-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=CzJ8lklm; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/8SG6LYh"; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 578146001993 X-Stat-Signature: htz8o9tqkmkfd3a9bih7j6x87dsp4qyw X-HE-Tag: 1629730723-67818 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: __unfreeze_partials() no longer needs to have irqs disabled, except for m= aking the spin_lock operations irq-safe, so convert the spin_locks operations a= nd remove the separate irq handling. Signed-off-by: Vlastimil Babka --- mm/slub.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 5f57e36e93ef..fc09ec3563b4 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2338,9 +2338,7 @@ static void __unfreeze_partials(struct kmem_cache *= s, struct page *partial_page) { struct kmem_cache_node *n =3D NULL, *n2 =3D NULL; struct page *page, *discard_page =3D NULL; - unsigned long flags; - - local_irq_save(flags); + unsigned long flags =3D 0; =20 while (partial_page) { struct page new; @@ -2352,10 +2350,10 @@ static void __unfreeze_partials(struct kmem_cache= *s, struct page *partial_page) n2 =3D get_node(s, page_to_nid(page)); if (n !=3D n2) { if (n) - spin_unlock(&n->list_lock); + spin_unlock_irqrestore(&n->list_lock, flags); =20 n =3D n2; - spin_lock(&n->list_lock); + spin_lock_irqsave(&n->list_lock, flags); } =20 do { @@ -2384,9 +2382,7 @@ static void __unfreeze_partials(struct kmem_cache *= s, struct page *partial_page) } =20 if (n) - spin_unlock(&n->list_lock); - - local_irq_restore(flags); + spin_unlock_irqrestore(&n->list_lock, flags); =20 while (discard_page) { page =3D discard_page; --=20 2.32.0