From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <naoya.horiguchi@nec.com>, <mhocko@suse.com>,
<minchan@kernel.org>, <cgoldswo@codeaurora.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH 3/3] mm/memory_hotplug: make HWPoisoned dirty swapcache pages unmovable
Date: Sat, 21 Aug 2021 17:42:46 +0800 [thread overview]
Message-ID: <20210821094246.10149-4-linmiaohe@huawei.com> (raw)
In-Reply-To: <20210821094246.10149-1-linmiaohe@huawei.com>
HWPoisoned dirty swapcache pages are kept for killing owner processes.
We should not offline these pages or do_swap_page() would access the
offline pages and lead to bad ending.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory_hotplug.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 9fd0be32a281..0488eed3327c 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1664,6 +1664,12 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
*/
if (PageOffline(page) && page_count(page))
return -EBUSY;
+ /*
+ * HWPoisoned dirty swapcache pages are definitely unmovable
+ * because they are kept for killing owner processes.
+ */
+ if (PageHWPoison(page) && PageSwapCache(page))
+ return -EBUSY;
if (!PageHuge(page))
continue;
--
2.23.0
next prev parent reply other threads:[~2021-08-21 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 9:42 [PATCH 0/3] Cleanup and fixups for memory hotplug Miaohe Lin
2021-08-21 9:42 ` [PATCH 1/3] mm/memory_hotplug: use helper zone_is_zone_device() to simplify the code Miaohe Lin
2021-08-23 8:20 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-23 9:11 ` Oscar Salvador
2021-08-23 12:14 ` David Hildenbrand
2021-08-21 9:42 ` [PATCH 2/3] mm/memory_hotplug: fix potential permanent lru cache disable Miaohe Lin
2021-08-23 8:21 ` HORIGUCHI NAOYA(堀口 直也)
2021-08-23 9:15 ` Oscar Salvador
2021-08-23 11:13 ` Miaohe Lin
2021-08-23 12:15 ` David Hildenbrand
2021-08-21 9:42 ` Miaohe Lin [this message]
2021-08-23 8:26 ` [PATCH 3/3] mm/memory_hotplug: make HWPoisoned dirty swapcache pages unmovable HORIGUCHI NAOYA(堀口 直也)
2021-08-23 9:14 ` Miaohe Lin
2021-11-04 22:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210821094246.10149-4-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=naoya.horiguchi@nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox