linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Namjae Jeon <namjae.jeon@samsung.com>,
	Steve French <stfrench@microsoft.com>
Subject: [linux-next:master 8015/9113] fs/ksmbd/vfs.c:79:18: error: implicit declaration of function 'lookup_one'; did you mean 'lookup_bdev'?
Date: Thu, 19 Aug 2021 19:58:05 +0800	[thread overview]
Message-ID: <202108191957.HpmYQXoc-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4713 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   33e65b1f975cd2814fc0ea9617250fc4c1d7a553
commit: 4b499755e1024f97e75411920a404b357af6e153 [8015/9113] ksmbd: fix lookup on idmapped mounts
config: nios2-randconfig-r033-20210819 (attached as .config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4b499755e1024f97e75411920a404b357af6e153
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout 4b499755e1024f97e75411920a404b357af6e153
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

Note: the linux-next/master HEAD 33e65b1f975cd2814fc0ea9617250fc4c1d7a553 builds fine.
      It may have been fixed somewhere.

All error/warnings (new ones prefixed by >>):

   fs/ksmbd/vfs.c: In function 'ksmbd_vfs_lock_parent':
>> fs/ksmbd/vfs.c:79:18: error: implicit declaration of function 'lookup_one'; did you mean 'lookup_bdev'? [-Werror=implicit-function-declaration]
      79 |         dentry = lookup_one(user_ns, child->d_name.name, parent,
         |                  ^~~~~~~~~~
         |                  lookup_bdev
>> fs/ksmbd/vfs.c:79:16: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      79 |         dentry = lookup_one(user_ns, child->d_name.name, parent,
         |                ^
   fs/ksmbd/vfs.c: In function 'ksmbd_vfs_mkdir':
   fs/ksmbd/vfs.c:223:19: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     223 |                 d = lookup_one(user_ns, dentry->d_name.name, dentry->d_parent,
         |                   ^
   fs/ksmbd/vfs.c: In function '__ksmbd_vfs_rename':
   fs/ksmbd/vfs.c:753:18: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     753 |         dst_dent = lookup_one(dst_user_ns, dst_name, dst_dent_parent,
         |                  ^
   fs/ksmbd/vfs.c: In function 'ksmbd_vfs_fp_rename':
   fs/ksmbd/vfs.c:816:19: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     816 |         src_child = lookup_one(user_ns, src_dent->d_name.name, src_dent_parent,
         |                   ^
   cc1: some warnings being treated as errors
--
   fs/ksmbd/smb2pdu.c: In function 'process_query_dir_entries':
>> fs/ksmbd/smb2pdu.c:3546:24: error: implicit declaration of function 'lookup_one'; did you mean 'lookup_bdev'? [-Werror=implicit-function-declaration]
    3546 |                 dent = lookup_one(user_ns, priv->d_info->name,
         |                        ^~~~~~~~~~
         |                        lookup_bdev
>> fs/ksmbd/smb2pdu.c:3546:22: warning: assignment to 'struct dentry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    3546 |                 dent = lookup_one(user_ns, priv->d_info->name,
         |                      ^
   cc1: some warnings being treated as errors


vim +79 fs/ksmbd/vfs.c

    62	
    63	/**
    64	 * ksmbd_vfs_lock_parent() - lock parent dentry if it is stable
    65	 *
    66	 * the parent dentry got by dget_parent or @parent could be
    67	 * unstable, we try to lock a parent inode and lookup the
    68	 * child dentry again.
    69	 *
    70	 * the reference count of @parent isn't incremented.
    71	 */
    72	int ksmbd_vfs_lock_parent(struct user_namespace *user_ns, struct dentry *parent,
    73				  struct dentry *child)
    74	{
    75		struct dentry *dentry;
    76		int ret = 0;
    77	
    78		inode_lock_nested(d_inode(parent), I_MUTEX_PARENT);
  > 79		dentry = lookup_one(user_ns, child->d_name.name, parent,
    80				    child->d_name.len);
    81		if (IS_ERR(dentry)) {
    82			ret = PTR_ERR(dentry);
    83			goto out_err;
    84		}
    85	
    86		if (dentry != child) {
    87			ret = -ESTALE;
    88			dput(dentry);
    89			goto out_err;
    90		}
    91	
    92		dput(dentry);
    93		return 0;
    94	out_err:
    95		inode_unlock(d_inode(parent));
    96		return ret;
    97	}
    98	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32783 bytes --]

             reply	other threads:[~2021-08-19 11:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 11:58 kernel test robot [this message]
2021-08-19 13:03 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108191957.HpmYQXoc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=namjae.jeon@samsung.com \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox